test: skip test that cannot pass under --node-builtin-modules-path · nodejs/node@98db2e7 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 98db2e7

Browse filesBrowse the repository at this point in the historyBrowse files

GeoffreyBooth

authored and

juanarbol

committed

test: skip test that cannot pass under --node-builtin-modules-path

PR-URL: #42834 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

1 parent ecb4d0b commit 98db2e7
Copy full SHA for 98db2e7

1 file changed

+4Lines changed: 4 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-worker-init-failure.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-worker-init-failure.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-worker-init-failure.js

+4Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -10,6 +10,10 @@ if (common.isWindows) {
10	10	common.skip('ulimit does not work on Windows.');
11	11	}
12	12
	13	+ if (process.config.variables.node_builtin_modules_path) {
	14	+ common.skip('this test cannot pass when Node.js is built with --node-builtin-modules-path');
	15	+ }
	16	+
13	17	// A reasonably low fd count. An empty node process
14	18	// creates around 30 fds for its internal purposes,
15	19	// so making it too low will crash the process early,

0 commit comments

Comments

0 (0)