test: skip test that cannot pass under --node-builtin-modules-path - #42834
Merged
nodejs-github-bot merged 1 commit intoApr 25, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@nodejs/testing |
Sorry, something went wrong.
aduh95
approved these changes
Apr 23, 2022
aduh95
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This test has also been failing for me locally, and I think skipping it make sense. Could it be a macOS specific limitation? I don't remember seeing this error when I was compiling on a Linux machine. If that's the case, we may want to add os.platform()==='darwin' in the condition.
Sorry, something went wrong.
21 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
It fails in Linux too. I triggered a CI build for master with --node-builtin-modules-path: https://ci.nodejs.org/job/node-test-commit-linux/45540/nodes=alpine-last-latest-x64/consoleFull 19:00:12 python3 ./configure --verbose --node-builtin-modules-path /home/iojs/build/workspace/node-test-commit-linux/
19:00:13 Node.js configure: Found Python 3.8.2…
19:00:13 Detected C++ compiler (CXX=ccache g++) version: 9.3.0
19:00:13 Detected C compiler (CC=ccache gcc) version: 9.3.0
19:00:13 Warning! Loading builtin modules from disk is for development
…
19:09:31 not ok 2950 parallel/test-worker-init-failure
19:09:31 ---
19:09:31 duration_ms: 1.23
19:09:31 severity: fail
19:09:31 exitcode: 1
19:09:31 stack: |-
19:09:31 child stdout:
19:09:31
19:09:31 child stderr: /home/iojs/build/workspace/node-test-commit-linux/out/Release/node[4537]: ../src/node_worker.cc:332:void node::worker::Worker::Run(): Assertion `(env_) != nullptr' failed.
19:09:31
19:09:31
19:09:31 node:assert:123
19:09:31 throw new AssertionError(obj);
19:09:31 ^
19:09:31
19:09:31 AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
19:09:31
19:09:31 null !== 0
19:09:31
19:09:31 at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/test/parallel/test-worker-init-failure.js:65:12)
19:09:31 at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/test/common/index.js:438:15)
19:09:31 at ChildProcess.emit (node:events:527:28)
19:09:31 at ChildProcess._handle.onexit (node:internal/child_process:291:12) {
19:09:31 generatedMessage: true,
19:09:31 code: 'ERR_ASSERTION',
19:09:31 actual: null,
19:09:31 expected: 0,
19:09:31 operator: 'strictEqual'
19:09:31 }
19:09:31
19:09:31 Node.js v19.0.0-pre
That’s the only failing test. |
Sorry, something went wrong.
16 tasks
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/42834 ✔ Done loading data for nodejs/node/pull/42834 ----------------------------------- PR info ------------------------------------ Title test: skip test that cannot pass under --node-builtin-modules-path (#42834) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch GeoffreyBooth:builtin-modules-path-test -> nodejs:master Labels test, flaky-test, author ready, worker Commits 1 - test: skip test that cannot pass under --node-builtin-modules-path Committers 1 - Geoffrey Booth PR-URL: https://github.com/nodejs/node/pull/42834 Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42834 Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 23 Apr 2022 04:42:56 GMT ✔ Approvals: 1 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/42834#pullrequestreview-950951284 ✖ This PR needs to wait 107 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-04-24T00:45:56Z: https://ci.nodejs.org/job/node-test-pull-request/43657/ - Querying data for job/node-test-pull-request/43657/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2221820838 |
Sorry, something went wrong.
targos
approved these changes
Apr 25, 2022
Copy link
Copy Markdown
Member
Author
The collaborator guide section “Waiting for approvals” says “Before landing pull requests, allow 48 hours for input from other collaborators.” Searching elsewhere in the document I see “At least two collaborators must approve a pull request before the pull request lands. One collaborator approval is enough if the pull request has been open for more than seven days.” So I guess that’s where the commit queue bot’s rules come from. I didn’t remember this second rule; it would make sense to mention it under “Waiting for approvals.” cc @Trott @aduh95 @targos |
Sorry, something went wrong.
This was referenced Apr 26, 2022
targos
pushed a commit
that referenced
this pull request
Apr 28, 2022
PR-URL: #42834 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
PR-URL: #42834 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
PR-URL: #42834 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #42834 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #42834 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#42834 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40879.
The test test-worker-init-failure.js cannot pass when Node is built using --node-builtin-modules-path, because the test intentionally lowers the limit of the number of files that can be concurrently opened and using builtin modules blows past this limit. See error in #40879 (comment).
The test is already skipped in Windows environments. This PR makes it also get skipped when Node is built using --node-builtin-modules-path. This makes development easier, as now I can develop using --node-builtin-modules-path and run the tests and expect all of them to pass (unless my new code broke something). cc @HarshithaKP @addaleax @Trott