test: fix flaky test-crypto-timing-safe-dqual-benchmarks · nodejs/node@9ad611c · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 9ad611c

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

targos

committed

test: fix flaky test-crypto-timing-safe-dqual-benchmarks

Fixes: #38226 PR-URL: #38476 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 13de4cf commit 9ad611c
Copy full SHA for 9ad611c

2 files changed

+5-3Lines changed: 5 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/bootstrap
  • node.js
• test/pummel
  • test-crypto-timing-safe-equal-benchmarks.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/bootstrap/node.js‎

Copy file name to clipboardExpand all lines: lib/internal/bootstrap/node.js

+4-2Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -46,7 +46,6 @@ const {
46	46	ObjectGetPrototypeOf,
47	47	ObjectPreventExtensions,
48	48	ObjectSetPrototypeOf,
49		- Proxy,
50	49	ReflectGet,
51	50	ReflectSet,
52	51	SymbolToStringTag,
@@ -108,8 +107,10 @@ const deprecationHandler = {
108	107
109	108	get(target, key, receiver) {
110	109	const val = ReflectGet(target, key, receiver);
111		- if (val != null && typeof val === 'object')
	110	+ if (val != null && typeof val === 'object') {
	111	+ // eslint-disable-next-line node-core/prefer-primordials
112	112	return new Proxy(val, deprecationHandler);
	113	+ }
113	114	return val;
114	115	},
115	116
@@ -119,6 +120,7 @@ const deprecationHandler = {
119	120	}
120	121	};
121	122
	123	+ // eslint-disable-next-line node-core/prefer-primordials
122	124	let processConfig = new Proxy(
123	125	JSONParse(nativeModule.config),
124	126	deprecationHandler);

Collapse file

‎test/pummel/test-crypto-timing-safe-equal-benchmarks.js‎

Copy file name to clipboardExpand all lines: test/pummel/test-crypto-timing-safe-equal-benchmarks.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -111,7 +111,7 @@ assert(
111	111	`timingSafeEqual should not leak information from its execution time (t=${t})`
112	112	);
113	113
114		- // As a sanity check to make sure the statistical tests are working, run the
	114	+ // As a coherence check to make sure the statistical tests are working, run the
115	115	// same benchmarks again, this time with an unsafe comparison function. In this
116	116	// case the t-value should be above the threshold.
117	117	const unsafeCompare = (bufA, bufB) => bufA.equals(bufB);

0 commit comments

Comments

0 (0)