FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix flaky test-crypto-timing-safe-dqual-benchmarks by Trott · Pull Request #38476 · nodejs/node · GitHub

/ node Public

test: fix flaky test-crypto-timing-safe-dqual-benchmarks - #38476

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:hopeful
Closed

test: fix flaky test-crypto-timing-safe-dqual-benchmarks#38476
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:hopeful

Conversation

Trott commented Apr 29, 2021

Copy link
Copy Markdown
Member

Fixes: #38226

github-actions Bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 29, 2021

This comment has been minimized.

Copy link
Copy Markdown
Collaborator

Trott commented Apr 30, 2021

Copy link
Copy Markdown
Member Author

You can see in #38226 where I bisected to determine that adding Proxy to bootstrap primordials is what caused this test to start failing much more frequently. I don't really understand the mechanics here, but maybe @not-an-aardvark or @aduh95 would be able to explain. (Or maybe not and it's a mystery.)

I still don't know if the issue here is with the test or with there really being a timing problem in Node.js core, but I'm guessing the latter but that it only manifests with a very fast CPU.

Regardless, fast-track to fix CI? Maybe leave the underlying issue open and investigate what's going on here?

Trott commented Apr 30, 2021

Copy link
Copy Markdown
Member Author

(dqual-> equal in the commit message, but that can happen on landing.)

Trott added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Apr 30, 2021

Trott commented Apr 30, 2021

Copy link
Copy Markdown
Member Author

https://ci.nodejs.org/job/node-stress-single-test/293/ is a stress test to show improvement. It will probably still show some failures, but not nearly as many as https://ci.nodejs.org/job/node-stress-single-test/273/ from this morning which ran against master and failed 941 times out of 1000 runs.

Trott commented Apr 30, 2021

Copy link
Copy Markdown
Member Author

@nodejs/testing

Trott requested review from aduh95 and jasnell April 30, 2021 02:37

Trott commented Apr 30, 2021

Copy link
Copy Markdown
Member Author

CI is green. Let's land this?

Stress test failed 192 times out of 1000 runs, which isn't great, but is way better than the current master branch which failed 941 times out of 1000 runs.

aduh95 commented Apr 30, 2021

Copy link
Copy Markdown
Contributor

Would it be worth trying to identify which Proxy call (line 112 or line 124, or both) is actually causing the issue? It can happen in a follow up PR though.

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

That's a very surprising result, but the stress test results look promising.

jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 30, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

jasnell added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. and removed needs-ci PRs that need a full CI run. labels Apr 30, 2021

jasnell commented Apr 30, 2021

Copy link
Copy Markdown
Member

Landed in c7ccab3

jasnell closed this Apr 30, 2021
jasnell pushed a commit that referenced this pull request Apr 30, 2021
Fixes: #38226

PR-URL: #38476
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Trott commented Apr 30, 2021

Copy link
Copy Markdown
Member Author

Would it be worth trying to identify which Proxy call (line 112 or line 124, or both) is actually causing the issue? It can happen in a follow up PR though.

I've got another fix in the works that should make it possible to add back the Proxy() stuff removed here. Stay tuned.

targos pushed a commit that referenced this pull request May 3, 2021
Fixes: #38226

PR-URL: #38476
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request May 3, 2021
Trott deleted the hopeful branch September 25, 2022 17:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

investigate flaky test-crypto-timing-safe-equal-benchmarks

6 participants


Back | FazBrowse Home | New Git URL