Commit 9b104be
quic: do not dereference shared_ptr after move
The stored pointer is assumed to be nullptr after std::move.
PR-URL: #47294
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>1 parent c81e114 commit 9b104be
1 file changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -38,16 +38,16 @@ Store::Store(std::shared_ptr<v8::BackingStore> store, | |||
| 38 | 38 | size_t length, | |
| 39 | 39 | size_t offset) | |
| 40 | 40 | : store_(std::move(store)), length_(length), offset_(offset) { | |
| 41 | - CHECK_LE(offset_, store->ByteLength()); | ||
| 42 | - CHECK_LE(length_, store->ByteLength() - offset_); | ||
| 41 | + CHECK_LE(offset_, store_->ByteLength()); | ||
| 42 | + CHECK_LE(length_, store_->ByteLength() - offset_); | ||
| 43 | 43 | } | |
| 44 | 44 | ||
| 45 | 45 | Store::Store(std::unique_ptr<v8::BackingStore> store, | |
| 46 | 46 | size_t length, | |
| 47 | 47 | size_t offset) | |
| 48 | 48 | : store_(std::move(store)), length_(length), offset_(offset) { | |
| 49 | - CHECK_LE(offset_, store->ByteLength()); | ||
| 50 | - CHECK_LE(length_, store->ByteLength() - offset_); | ||
| 49 | + CHECK_LE(offset_, store_->ByteLength()); | ||
| 50 | + CHECK_LE(length_, store_->ByteLength() - offset_); | ||
| 51 | 51 | } | |
| 52 | 52 | ||
| 53 | 53 | Store::Store(v8::Local<v8::ArrayBuffer> buffer, Option option) | |
0 commit comments