quic: do not dereference shared_ptr after move - #47294
Closed
tniessen wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The stored pointer is assumed to be nullptr after std::move.
jasnell
reviewed
Mar 29, 2023
Comment thread
src/quic/data.cc
| CHECK_LE(offset_, store->ByteLength()); | ||
| CHECK_LE(length_, store->ByteLength() - offset_); | ||
| CHECK_LE(offset_, store_->ByteLength()); | ||
| CHECK_LE(length_, store_->ByteLength() - offset_); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
oh! ha, good catch.
Sorry, something went wrong.
jasnell
approved these changes
Mar 29, 2023
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
Sorry, something went wrong.
anonrig
approved these changes
Mar 29, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
Mar 29, 2023
The stored pointer is assumed to be nullptr after std::move. PR-URL: #47294 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Copy link
Copy Markdown
Member
|
This PR depends on #47263 which was flagged as "dont-land-on-v19.x". Therefore, I'm adding the dont-land-x labels here too. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stored pointer is assumed to be nullptr after std::move.