| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Just a heads up but the first and the last of these three link to the wrong pull request:
|
Sorry, something went wrong.
|
Just a note, this changelog will be rebased after the next v19 version goes out. So, I'll remove the semver-minor and semver-patch commits from the changelog for now. |
Sorry, something went wrong.
|
are there any new core modules that would cause is-core-module's tests to fail? (I'm not sure if that CI's been ran yet) |
Sorry, something went wrong.
|
@ljharb not is-core-module, but from a recent CITGM run (that was for a crypto-related change on main): citgm.resolve-v1.22.1
not ok 200 inspector/promises is a core module
---
operator: ok
expected: true
actual: undefined
at: Test.<anonymous> (/home/iojs/tmp/citgm_tmp/928455fa-bdcb-4d45-9fa5-88b35c12dc44/resolve/test/core.js:52:16)
stack: |-
Error: inspector/promises is a core module
at Test.assert [as _assert] (/home/iojs/tmp/citgm_tmp/928455fa-bdcb-4d45-9fa5-88b35c12dc44/resolve/node_modules/tape/lib/test.js:312:48)
at Test.bound [as _assert] (/home/iojs/tmp/citgm_tmp/928455fa-bdcb-4d45-9fa5-88b35c12dc44/resolve/node_modules/tape/lib/test.js:95:17)
at Test.assert (/home/iojs/tmp/citgm_tmp/928455fa-bdcb-4d45-9fa5-88b35c12dc44/resolve/node_modules/tape/lib/test.js:431:7)
at Test.bound [as ok] (/home/iojs/tmp/citgm_tmp/928455fa-bdcb-4d45-9fa5-88b35c12dc44/resolve/node_modules/tape/lib/test.js:95:17)
at Test.<anonymous> (/home/iojs/tmp/citgm_tmp/928455fa-bdcb-4d45-9fa5-88b35c12dc44/resolve/test/core.js:52:16)
at Test.bound [as _cb] (/home/iojs/tmp/citgm_tmp/928455fa-bdcb-4d45-9fa5-88b35c12dc44/resolve/node_modules/tape/lib/test.js:95:17)
at Test.run (/home/iojs/tmp/citgm_tmp/928455fa-bdcb-4d45-9fa5-88b35c12dc44/resolve/node_modules/tape/lib/test.js:115:28)
at Test.bound [as run] (/home/iojs/tmp/citgm_tmp/928455fa-bdcb-4d45-9fa5-88b35c12dc44/resolve/node_modules/tape/lib/test.js:95:17)
at Test._end (/home/iojs/tmp/citgm_tmp/928455fa-bdcb-4d45-9fa5-88b35c12dc44/resolve/node_modules/tape/lib/test.js:218:5)
at Test.bound [as _end] (/home/iojs/tmp/citgm_tmp/928455fa-bdcb-4d45-9fa5-88b35c12dc44/resolve/node_modules/tape/lib/test.js:95:17)
...
inspector/promises landed on v19.0.0 so I'm surprised to see this. |
Sorry, something went wrong.
|
@targos inspector/promises (with and without the node: prefix) is supported in is-core-module v2.11.0, and resolve v1 and v2 both depend on is-core-module with a ^ that includes that, as of resolve v1.18+. Perhaps it's a lockfile issue? |
Sorry, something went wrong.
|
I don't know how it can be happening. CITGM should do the following:
|
Sorry, something went wrong.
|
@targos hmm - when i run is-core-module's tests on the latest node v20 nightly, i get 3 failures - wasi and test/reporters are now requireable (not on 19), but i don't get a failure on inspector/promises. Both of those seem like notable changes, if intentional - could they be listed in that section? |
Sorry, something went wrong.
|
@ljharb I can reproduce locally with Node.js 19.8.1: wget https://github.com/browserify/resolve/archive/8eea601093612229da100e9dfbeb4b2b47693aa6.zip unzip 8eea601093612229da100e9dfbeb4b2b47693aa6.zip cd resolve-8eea601093612229da100e9dfbeb4b2b47693aa6 npm i npm run tests-only Two failures: not ok 200 inspector/promises is a core module not ok 334 inspector/promises is a core module npm ls is-core-module shows that is-core-module@2.11.0 is installed. |
Sorry, something went wrong.
|
@targos thanks, i'll keep trying to reproduce. |
Sorry, something went wrong.
|
@targos Actually, I can reproduce it on resolve v1, which makes sense because v1 uses data hardcoded-on-publish from is-core-module. I've fixed that so it uses is-core-module in browserify/resolve@ed8f81b, and I've just published v1.22.2 which should pass. Thanks! |
Sorry, something went wrong.
|
It might be good to include an undici release with nodejs/undici#2049 included. |
Sorry, something went wrong.
|
Node 19+ is breaking some undici tests. Would be good to have those fixed before v20. Help would be appreciated. nodejs/undici#2020 |
Sorry, something went wrong.
|
I will need to add a few important commits to this release. Therefore, I'll sync v20.x with main right after v19.9.0 release (#47441), and this will be the last sync unless something critical arises. FYI @nodejs/collaborators @nodejs/tsc. |
Sorry, something went wrong.
|
I've released a new version of undici which we would like have included. |
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
|
The V8 CI is failing with: v8tests.mjsunit/regress/regress-1320641 /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/regress/regress-1320641.js:8: RangeError: Array buffer allocation failed
const xs = new Uint16Array(3775336418);
^
RangeError: Array buffer allocation failed
at new ArrayBuffer (<anonymous>)
at new Uint16Array (<anonymous>)
at foo (/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/regress/regress-1320641.js:8:14)
at /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/regress/regress-1320641.js:12:1
@nodejs/v8 @nodejs/v8-update |
Sorry, something went wrong.
|
This test is marked as flaky, we can ignore it. The job failed because of nodejs/build#3050 |
Sorry, something went wrong.
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
There was a problem hiding this comment.
🎉
Sorry, something went wrong.
Notable Changes: crypto: * (SEMVER-MAJOR) use WebIDL converters in WebCryptoAPI (Filip Skokan) #46067 deps: * update ada to 2.0.0 (Node.js GitHub Bot) #47339 esm: * move hook execution to separate thread (Jacob Smith) #44710 sea: * use JSON configuration and blob content for SEA (Joyee Cheung) #47125 src,process: * (SEMVER-MINOR) add permission model (Rafael Gonzaga) #44004 url: * drop ICU requirement for parsing hostnames (Yagiz Nizipli) #47339 * use ada::url_aggregator for parsing urls (Yagiz Nizipli) #47339 * (SEMVER-MAJOR) runtime-deprecate url.parse() with invalid ports (Rich Trott) #45526 Semver-Major Commits: * [9fafb0a] - (SEMVER-MAJOR) async_hooks: deprecate the AsyncResource.bind asyncResource property (James M Snell) #46432 * [1948d37] - (SEMVER-MAJOR) buffer: check INSPECT_MAX_BYTES with validateNumber (Umuoy) #46599 * [7bc0e6a] - (SEMVER-MAJOR) buffer: graduate File from experimental and expose as global (Khafra) #47153 * [671ffd7] - (SEMVER-MAJOR) buffer: use min/max of `validateNumber` (Deokjin Kim) #45796 * [ab1614d] - (SEMVER-MAJOR) build: reset embedder string to "-node.0" (Michaël Zasso) #47251 * [c1bcdbc] - (SEMVER-MAJOR) build: warn for gcc versions earlier than 10.1 (Richard Lau) #46806 * [649f68f] - (SEMVER-MAJOR) build: reset embedder string to "-node.0" (Yagiz Nizipli) #45579 * [9374700] - (SEMVER-MAJOR) crypto: remove DEFAULT_ENCODING (Tobias Nießen) #47182 * [1640aeb] - (SEMVER-MAJOR) crypto: remove obsolete SSL_OP_* constants (Tobias Nießen) #47073 * [c2e4b1f] - (SEMVER-MAJOR) crypto: remove ALPN_ENABLED (Tobias Nießen) #47028 * [3ef38c4] - (SEMVER-MAJOR) crypto: use WebIDL converters in WebCryptoAPI (Filip Skokan) #46067 * [08af023] - (SEMVER-MAJOR) crypto: runtime deprecate replaced rsa-pss keygen parameters (Filip Skokan) #45653 * [7eb0ac3] - (SEMVER-MAJOR) deps: patch V8 to support compilation on win-arm64 (Michaël Zasso) #47251 * [a7c129f] - (SEMVER-MAJOR) deps: silence irrelevant V8 warning (Michaël Zasso) #47251 * [6f5655a] - (SEMVER-MAJOR) deps: always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #47251 * [f226350] - (SEMVER-MAJOR) deps: update V8 to 11.3.244.4 (Michaël Zasso) #47251 * [d6dae74] - (SEMVER-MAJOR) deps: V8: cherry-pick f1c888e7093e (Michaël Zasso) #45579 * [56c4365] - (SEMVER-MAJOR) deps: fix V8 build on Windows with MSVC (Michaël Zasso) #45579 * [51ab98c] - (SEMVER-MAJOR) deps: silence irrelevant V8 warning (Michaël Zasso) #45579 * [9f84d3e] - (SEMVER-MAJOR) deps: V8: fix v8-cppgc.h for MSVC (Jiawen Geng) #45579 * [f2318cd] - (SEMVER-MAJOR) deps: fix V8 build issue with inline methods (Jiawen Geng) #45579 * [16e03e7] - (SEMVER-MAJOR) deps: update V8 to 10.9.194.4 (Yagiz Nizipli) #45579 * [6473f5e] - (SEMVER-MAJOR) doc: update toolchains used for Node.js 20 releases (Richard Lau) #47352 * [cc18fd9] - (SEMVER-MAJOR) events: refactor to use `validateNumber` (Deokjin Kim) #45770 * [ff92b40] - (SEMVER-MAJOR) http: close the connection after sending a body without declared length (Tim Perry) #46333 * [2a29df6] - (SEMVER-MAJOR) http: keep HTTP/1.1 conns alive even if the Connection header is removed (Tim Perry) #46331 * [391dc74] - (SEMVER-MAJOR) http: throw error if options of http.Server is array (Deokjin Kim) #46283 * [ed3604c] - (SEMVER-MAJOR) http: server check Host header, to meet RFC 7230 5.4 requirement (wwwzbwcom) #45597 * [88d71dc] - (SEMVER-MAJOR) lib: refactor to use min/max of `validateNumber` (Deokjin Kim) #45772 * [e4d641f] - (SEMVER-MAJOR) lib: refactor to use validators in http2 (Debadree Chatterjee) #46174 * [0f3e531] - (SEMVER-MAJOR) lib: performance improvement on readline async iterator (Thiago Oliveira Santos) #41276 * [5b5898a] - (SEMVER-MAJOR) lib,src: update exit codes as per todos (Debadree Chatterjee) #45841 * [55321ba] - (SEMVER-MAJOR) net: enable autoSelectFamily by default (Paolo Insogna) #46790 * [2d0d997] - (SEMVER-MAJOR) process: remove `process.exit()`, `process.exitCode` coercion to integer (Daeyeon Jeong) #43716 * [dc06df3] - (SEMVER-MAJOR) readline: refactor to use `validateNumber` (Deokjin Kim) #45801 * [295b2f3] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 115 (Michaël Zasso) #47251 * [3803b02] - (SEMVER-MAJOR) src: share common code paths for SEA and embedder script (Anna Henningsen) #46825 * [e8bddac] - (SEMVER-MAJOR) src: apply ABI-breaking API simplifications (Anna Henningsen) #46705 * [f84de0a] - (SEMVER-MAJOR) src: use uint32_t for process initialization flags enum (Anna Henningsen) #46427 * [a624277] - (SEMVER-MAJOR) src: fix ArrayBuffer::Detach deprecation (Michaël Zasso) #45579 * [dd5c39a] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 112 (Yagiz Nizipli) #45579 * [63eca7f] - (SEMVER-MAJOR) stream: validate readable defaultEncoding (Marco Ippolito) #46430 * [9e7093f] - (SEMVER-MAJOR) stream: validate writable defaultEncoding (Marco Ippolito) #46322 * [fb91ee4] - (SEMVER-MAJOR) test: make trace-gc-flag tests less strict (Yagiz Nizipli) #45579 * [eca6180] - (SEMVER-MAJOR) test: adapt test-v8-stats for V8 update (Michaël Zasso) #45579 * [c03354d] - (SEMVER-MAJOR) test: test case for multiple res.writeHead and res.getHeader (Marco Ippolito) #45508 * [c733cc0] - (SEMVER-MAJOR) test_runner: mark module as stable (Colin Ihrig) #46983 * [7ce2232] - (SEMVER-MAJOR) tools: update V8 gypfiles for 11.1 (Michaël Zasso) #47251 * [ca4bd30] - (SEMVER-MAJOR) tools: update V8 gypfiles for 11.0 (Michaël Zasso) #47251 * [58b06a2] - (SEMVER-MAJOR) tools: update V8 gypfiles (Michaël Zasso) #45579 * [027841c] - (SEMVER-MAJOR) url: use private properties for brand check (Yagiz Nizipli) #46904 * [3bed5f1] - (SEMVER-MAJOR) url: runtime-deprecate url.parse() with invalid ports (Rich Trott) #45526 * [7c76fdd] - (SEMVER-MAJOR) util,doc: mark parseArgs() as stable (Colin Ihrig) #46718 * [4b52727] - (SEMVER-MAJOR) wasi: make version non-optional (Michael Dawson) #47391 Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #47441 Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
* Blog: v20.0.0 release post Refs: nodejs/node#47381 * announce: Node.js 20 release announcement
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
*This is just an early draft proposal to enable test builds.
2023-04-18, Version 20.0.0 (Current), @RafaelGSS
We're excited to announce the release of Node.js 20! Highlights include the new Node.js Permission Model,
a synchronous import.meta.resolve, a stable test_runner, updates of the V8 JavaScript engine to 11.3, Ada to 2.0,
and more!
As a reminder, Node.js 20 will enter long-term support (LTS) in October, but until then, it will be the "Current" release for the next six months.
We encourage you to explore the new features and benefits offered by this latest release and evaluate their potential impact on your applications.
Notable Changes
Permission Model
Node.js now has an experimental feature called the Permission Model.
It allows developers to restrict access to specific resources during program execution, such as file system operations,
child process spawning, and worker thread creation.
The API exists behind a flag --experimental-permission which when enabled will restrict access to all available permissions.
By using this feature, developers can prevent their applications from accessing or modifying sensitive data or running potentially harmful code.
More information about the Permission Model can be found in the Node.js documentation.
The Permission Model was a contribution by Rafael Gonzaga in #44004.
Custom ESM loader hooks run on dedicated thread
ESM hooks supplied via loaders (--experimental-loader=foo.mjs) now run in a dedicated thread, isolated from the main thread.
This provides a separate scope for loaders and ensures no cross-contamination between loaders and application code.
Synchronous import.meta.resolve()
In alignment with browser behavior, this function now returns synchronously.
Despite this, user loader resolve hooks can still be defined as async functions (or as sync functions, if the author prefers).
Even when there are async resolve hooks loaded, import.meta.resolve will still return synchronously for application code.
Contributed by Anna Henningsen, Antoine du Hamel, Geoffrey Booth, Guy Bedford, Jacob Smith, and Michaël Zasso in #44710
V8 11.3
The V8 engine is updated to version 11.3, which is part of Chromium 113.
This version includes three new features to the JavaScript API:
The V8 update was a contribution by Michaël Zasso in #47251.
Stable Test Runner
The recent update to Node.js, version 20, includes an important change to the test_runner module. The module has been marked as stable after a recent update.
Previously, the test_runner module was experimental, but this change marks it as a stable module that is ready for production use.
Contributed by Colin Ihrig in #46983
Ada 2.0
Node.js v20 comes with the latest version of the URL parser, Ada. This update brings significant performance improvements
to URL parsing, including enhancements to the url.domainToASCII and url.domainToUnicode functions in node:url.
Ada 2.0 has been integrated into the Node.js codebase, ensuring that all parts of the application can benefit from the
improved performance. Additionally, Ada 2.0 features a significant performance boost over its predecessor, Ada 1.0.4,
while also eliminating the need for the ICU requirement for URL hostname parsing.
Contributed by Yagiz Nizipli and Daniel Lemire in #47339
Preparing single executable apps now requires injecting a Blob
Building a single executable app now requires injecting a blob prepared by
Node.js from a JSON config instead of injecting the raw JS file.
This opens up the possibility of embedding multiple co-existing resources into the SEA (Single Executable Apps).
Contributed by Joyee Cheung in #47125
Web Crypto API
Web Crypto API functions' arguments are now coerced and validated as per their WebIDL definitions like in other Web Crypto API implementations.
This further improves interoperability with other implementations of Web Crypto API.
Contributed by Filip Skokan in #46067.
Official support for ARM64 Windows
Node.js now includes binaries for ARM64 Windows, allowing for native execution on the platform.
The MSI, zip/7z packages, and executable are available from the Node.js download site along with all other platforms.
The CI system was updated and all changes are now fully tested on ARM64 Windows, to prevent regressions and ensure compatibility.
ARM64 Windows was upgraded to tier 2 support by Stefan Stojanovic in #47233.
WASI version must now be specified
When new WASI() is called, the version option is now required and has no default value.
Any code that relied on the default for the version will need to be updated to request a specific version.
Contributed by Michael Dawson in #47391.
Deprecations and Removals
url.parse() accepts URLs with ports that are not numbers. This behavior might result in host name spoofing with unexpected input.
These URLs will throw an error in future versions of Node.js, as the WHATWG URL API does already.
Starting with Node.js 20, these URLS cause url.parse() to emit a warning.
Semver-Major Commits
Semver-Minor Commits
Semver-Patch Commits