test: unused callback variables removed - #47167
Merged
Trott merged 1 commit intoApr 10, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
anonrig
approved these changes
Mar 20, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
debadree25
approved these changes
Mar 20, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Mar 20, 2023
19 tasks
Copy link
Copy Markdown
Member
|
Hi @angellovc and thank you for the contribution! Please take a look at the commit message guidlines. A better commit message would be test: remove unused callback variables, for example. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Of course I will, thanks. Is it necessary to change this one? |
Sorry, something went wrong.
cjihrig
approved these changes
Mar 21, 2023
19 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
33 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Mar 30, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
watilde
approved these changes
Apr 5, 2023
Unused variables were removed from stream-exception test. PR-URL: nodejs#47167 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Trott
force-pushed
the
angellovc/test-unused-variables-removed-from-stream-exceptions
branch
from
fb0a3a4 to
e301ba4
Compare
April 10, 2023 17:43
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 13, 2023
Unused variables were removed from stream-exception test. PR-URL: #47167 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Unused variables were removed from stream-exception test. PR-URL: #47167 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
Unused variables were removed from stream-exception test. PR-URL: nodejs#47167 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non used variables were removed from stream-exception test