quic: add additional utilities for quic (part 2) - #47289
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
anonrig
reviewed
Mar 29, 2023
Comment thread
src/quic/sessionticket.cc
Outdated
Comment thread
src/quic/sessionticket.cc
Outdated
Comment thread
src/quic/sessionticket.cc
Outdated
Comment thread
src/quic/sessionticket.cc
Outdated
Comment thread
src/quic/sessionticket.h
Outdated
Comment thread
src/quic/sessionticket.h
Outdated
Comment thread
src/quic/tokens.cc
Outdated
anonrig
approved these changes
Mar 29, 2023
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Comment thread
src/quic/sessionticket.cc
Outdated
tniessen
reviewed
Mar 30, 2023
tniessen
approved these changes
Mar 30, 2023
Comment thread
src/quic/sessionticket.cc
Outdated
Qard
approved these changes
Mar 31, 2023
* add TokenSecret, StatelessResetToken, RetryToken, and RegularToken * add SessionTicket implementation
Qard
approved these changes
Mar 31, 2023
jasnell
added a commit
that referenced
this pull request
Mar 31, 2023
* add TokenSecret, StatelessResetToken, RetryToken, and RegularToken * add SessionTicket implementation PR-URL: #47289 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second PR incrementally adding QUIC impl details. Again, the idea is to space these out over multiple PRS to make it easier to review instead of the big monolith that #44325 is. Easiest to review each commit individually.