FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: bootstrap prepare stack trace callback in shadow realm by legendecas · Pull Request #47107 · nodejs/node · GitHub

/ node Public

src: bootstrap prepare stack trace callback in shadow realm - #47107

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:shadow-realm/prepare-stack
Apr 4, 2023
ConversationCommits (1)ChecksFiles changed
Merged

src: bootstrap prepare stack trace callback in shadow realm#47107
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:shadow-realm/prepare-stack

Conversation

legendecas commented Mar 15, 2023

Copy link
Copy Markdown
Member

Bootstrap per-realm callbacks like prepare_stack_trace_callback in
the ShadowRealm. This enables stack trace decoration in the ShadowRealm.

legendecas added the realm Issues and PRs related to the ShadowRealm API and node::Realm label Mar 15, 2023

nodejs-github-bot commented Mar 15, 2023 •
edited by legendecas
Loading

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup
  • @nodejs/realm

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 15, 2023
joyeecheung reviewed Mar 15, 2023
View reviewed changes
Comment thread lib/internal/bootstrap/realm.js Outdated
Comment thread test/parallel/test-shadow-realm-prepare-stack-trace.js Outdated
Comment thread src/api/environment.cc Outdated
legendecas force-pushed the shadow-realm/prepare-stack branch 2 times, most recently from 99977c5 to 86fd9e6 Compare March 20, 2023 11:39
mcollina approved these changes Mar 20, 2023
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

legendecas force-pushed the shadow-realm/prepare-stack branch from 86fd9e6 to efc44cc Compare March 29, 2023 17:57
legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 30, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 30, 2023

nodejs-github-bot commented Mar 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50683/

nodejs-github-bot commented Mar 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50695/

github-actions Bot mentioned this pull request Mar 31, 2023
Open
34 tasks
cjihrig approved these changes Mar 31, 2023
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I just found myself needing this. LGTM once initializeWASI() is removed from pre_execution.js.

github-actions Bot mentioned this pull request Apr 1, 2023
Open
38 tasks
src: bootstrap prepare stack trace callback in shadow realm
571dadd 
Bootstrap per-realm callbacks like `prepare_stack_trace_callback` in
the ShadowRealm. This enables stack trace decoration in the ShadowRealm.
legendecas force-pushed the shadow-realm/prepare-stack branch from 0f88844 to 571dadd Compare April 2, 2023 09:46

legendecas commented Apr 2, 2023

Copy link
Copy Markdown
Member Author

Rebased and removed initializeWASI() changes.

legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 2, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 2, 2023

nodejs-github-bot commented Apr 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50813/

nodejs-github-bot commented Apr 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50822/

nodejs-github-bot commented Apr 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50829/

github-actions Bot mentioned this pull request Apr 3, 2023
Open
28 tasks

nodejs-github-bot commented Apr 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50840/

nodejs-github-bot commented Apr 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50842/

nodejs-github-bot commented Apr 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50845/

nodejs-github-bot commented Apr 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50852/

nodejs-github-bot commented Apr 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50865/

legendecas commented Apr 3, 2023

Copy link
Copy Markdown
Member Author

CI is green. @nodejs/realm would you mind taking a look again with the rebase? thanks!

github-actions Bot mentioned this pull request Apr 4, 2023
Open
29 tasks
legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 4, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 4, 2023
nodejs-github-bot merged commit 3a014dc into nodejs:main Apr 4, 2023

nodejs-github-bot commented Apr 4, 2023

Copy link
Copy Markdown
Collaborator

Landed in 3a014dc

legendecas deleted the shadow-realm/prepare-stack branch April 4, 2023 02:04
github-actions Bot mentioned this pull request Apr 5, 2023
Open
26 tasks
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
src: bootstrap prepare stack trace callback in shadow realm
122c7ff 
Bootstrap per-realm callbacks like `prepare_stack_trace_callback` in
the ShadowRealm. This enables stack trace decoration in the ShadowRealm.

PR-URL: #47107
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
src: bootstrap prepare stack trace callback in shadow realm
21832b5 
Bootstrap per-realm callbacks like `prepare_stack_trace_callback` in
the ShadowRealm. This enables stack trace decoration in the ShadowRealm.

PR-URL: #47107
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

RafaelGSS commented Apr 7, 2023

Copy link
Copy Markdown
Member

Hi @legendecas! I had to drop #46809 and this PR isn't landing cleanly on v19.x-staging. Can you please create a manual backport? If it strictly depends on #46809 feel free to change the label to backport-blocked-v19.x.

RafaelGSS mentioned this pull request Apr 11, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
src: bootstrap prepare stack trace callback in shadow realm
698508a 
Bootstrap per-realm callbacks like `prepare_stack_trace_callback` in
the ShadowRealm. This enables stack trace decoration in the ShadowRealm.

PR-URL: #47107
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2023
src: bootstrap prepare stack trace callback in shadow realm
d35f870 
Bootstrap per-realm callbacks like `prepare_stack_trace_callback` in
the ShadowRealm. This enables stack trace decoration in the ShadowRealm.

PR-URL: #47107
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
src: bootstrap prepare stack trace callback in shadow realm
110bd4b 
Bootstrap per-realm callbacks like `prepare_stack_trace_callback` in
the ShadowRealm. This enables stack trace decoration in the ShadowRealm.

PR-URL: nodejs/node#47107
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
src: bootstrap prepare stack trace callback in shadow realm
bf56be1 
Bootstrap per-realm callbacks like `prepare_stack_trace_callback` in
the ShadowRealm. This enables stack trace decoration in the ShadowRealm.

PR-URL: nodejs/node#47107
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes
anonrig anonrig approved these changes
cjihrig cjihrig approved these changes
joyeecheung joyeecheung approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. realm Issues and PRs related to the ShadowRealm API and node::Realm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL