tools: automate cjs-module-lexer dependency update - #47446
Merged
nodejs-github-bot merged 1 commit intoApr 9, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
debadree25
reviewed
Apr 6, 2023
Comment thread
tools/dep_updaters/update-cjs-module-lexer.sh
Outdated
debadree25
approved these changes
Apr 6, 2023
ShogunPanda
approved these changes
Apr 7, 2023
ShogunPanda
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
Comment thread
.github/workflows/tools.yml
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Not a blocker, but I can't really say if you left this while debugging or it's actually needed. Just pointing this out for you to double check.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
for debugging purposes we use it in every job
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
The script is missing this step to update the esm docs: node/doc/contributing/maintaining-cjs-module-lexer.md Lines 47 to 49 in 0c76922 |
Sorry, something went wrong.
marco-ippolito
force-pushed
the
feat/automate-cjs-module-lexer-update
branch
from
1f9a35c to
bf1e623
Compare
April 8, 2023 10:03
guybedford
approved these changes
Apr 8, 2023
RafaelGSS
approved these changes
Apr 8, 2023
lpinca
approved these changes
Apr 9, 2023
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 13, 2023
PR-URL: #47446 Refs: nodejs/security-wg#828 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Apr 24, 2023
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47446 Refs: nodejs/security-wg#828 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47446 Refs: nodejs/security-wg#828 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
Refs: nodejs#47446 PR-URL: nodejs#47701 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/security-wg#828
@nodejs/security-wg