FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: remove unnecessary status check on test-release-npm by RafaelGSS · Pull Request #47516 · nodejs/node · GitHub

/ node Public

test: remove unnecessary status check on test-release-npm - #47516

Closed
RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:fix/test-release-npm
ConversationCommits (1)ChecksFiles changed
Closed

test: remove unnecessary status check on test-release-npm#47516
RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:fix/test-release-npm

Conversation

RafaelGSS commented Apr 11, 2023

Copy link
Copy Markdown
Member

test-release-npm is failing on #47381 and it seems related to #43716. However, this asserting seems unnecesary, so rather than adjust it (either on npm side or node.js) sounds reasonable to remove that check.

However, it doesn't mean there's no bug in that change. It seems process.exitCode isn't considered when process.exit() is called with undefined. cc: @daeyeon

test: remove unnecessary status check on test-release-npm
b8c2bf5 
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
RafaelGSS requested a review from targos April 11, 2023 21:06
nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 11, 2023

richardlau commented Apr 11, 2023

Copy link
Copy Markdown
Member

cc @nodejs/npm

wraithgar approved these changes Apr 11, 2023
View reviewed changes

wraithgar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Agreed that in light of #43716 this is an unnecessary check.

RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 12, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 12, 2023

nodejs-github-bot commented Apr 12, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51143/

nodejs-github-bot commented Apr 12, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51160/

nodejs-github-bot commented Apr 12, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51165/

RafaelGSS added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 12, 2023

github-actions Bot commented Apr 12, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @RafaelGSS. Please 👍 to approve.

RafaelGSS commented Apr 12, 2023

Copy link
Copy Markdown
Member Author

I'm requesting fast-track because I need to include it on v20.0.0 and run the CI/release candidate and so on.

RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 12, 2023

RafaelGSS commented Apr 12, 2023

Copy link
Copy Markdown
Member Author

The GitHub UI shows a pending CI, but the CI link shows it as finished. Should I land it manually? @nodejs/build

RafaelGSS marked this pull request as draft April 12, 2023 21:41
RafaelGSS marked this pull request as ready for review April 12, 2023 21:41

Trott commented Apr 12, 2023

Copy link
Copy Markdown
Member

The GitHub UI shows a pending CI, but the CI link shows it as finished. Should I land it manually? @nodejs/build

Yes, if you are reasonably certain that the GitHub widget is showing bad information and CI is in fact complete and successful, you can always land manually.

github-actions Bot mentioned this pull request Apr 13, 2023
Open
36 tasks

RafaelGSS commented Apr 13, 2023

Copy link
Copy Markdown
Member Author

Landed in e67b944

RafaelGSS added a commit that referenced this pull request Apr 13, 2023
test: remove unnecessary status check on test-release-npm
e67b944 
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: #47516
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS closed this Apr 13, 2023
RafaelGSS mentioned this pull request Apr 13, 2023
Merged
RafaelGSS added a commit that referenced this pull request Apr 13, 2023
test: remove unnecessary status check on test-release-npm
7359b92 
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: #47516
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
test: remove unnecessary status check on test-release-npm
0ebd80f 
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: #47516
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
test: remove unnecessary status check on test-release-npm
bd1eb14 
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: nodejs#47516
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams mentioned this pull request Jul 10, 2023
Merged
panva removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Qard Qard approved these changes
lpinca lpinca approved these changes
targos Awaiting requested review from targos
+1 more reviewer
wraithgar wraithgar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL