FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: move update-acorn.sh to dep_updaters by marco-ippolito · Pull Request #47382 · nodejs/node · GitHub

/ node Public

tools: move update-acorn.sh to dep_updaters - #47382

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:feat/update-acorn
Apr 10, 2023
Merged

tools: move update-acorn.sh to dep_updaters#47382
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:feat/update-acorn

Conversation

marco-ippolito commented Apr 3, 2023
edited
Loading

Copy link
Copy Markdown
Member

Refs: nodejs/security-wg#828
@nodejs/security-wg

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/tsc

nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Apr 3, 2023

targos commented Apr 3, 2023

Copy link
Copy Markdown
Member

Can you please make the commit message clearer?

Comment thread tools/dep_updaters/update-acorn.sh Outdated
Comment thread tools/dep_updaters/update-acorn-walk.sh Outdated
marco-ippolito changed the title tools: maintaining acorn tools: move update-acorn.sh to dep_updaters Apr 3, 2023
marco-ippolito requested a review from targos April 7, 2023 09:00

ShogunPanda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

marco-ippolito added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 7, 2023
lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 10, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 10, 2023
nodejs-github-bot merged commit c2b54fb into nodejs:main Apr 10, 2023

Copy link
Copy Markdown
Collaborator

Landed in c2b54fb

RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
PR-URL: #47382
Refs: nodejs/security-wg#828
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #47382
Refs: nodejs/security-wg#828
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
PR-URL: nodejs#47382
Refs: nodejs/security-wg#828
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL