http: keep HTTP/1.1 conns alive even if the Connection header is removed by pimterry · Pull Request #46331 · nodejs/node · GitHub

Previously persistence was completed disabled if you removed this header, which is not correct for modern HTTP, where the header is optional and all connections should persist by default regardless. See #46321 for more context.

This header is required to enable keep alive for HTTP/1.0 and older. This PR doesn't explicitly check the version, but the shouldKeepAlive variable that's used here is set by the HTTP parser, which does check this (among other conditions) and there's a test here to confirm that.

As noted in #46321, we should test this for ecosystem impact, since this incorrect default dates back to 2012 and it may be relied on elsewhere.

Fixes #46321

Previously persistence was completed disabled if you removed this header, which is not correct for modern HTTP, where the header is optional and all connections should persist by default regardless.

Review requested:

@nodejs/http
@nodejs/net

LGTM. Let's run CITGM first and then I'll approve.

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3082/

lgtm

CI: https://ci.nodejs.org/job/node-test-pull-request/49151/

Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

This breaks both Fastify and Undici.

Here is the fastify break:

ok 9 - Current opened connection should continue to work after closing and return "connection: close" header - return503OnClosing: false, skip Node >= v19.x # SKIP
     # Subtest: Current opened connection should NOT continue to work after closing and return "connection: close" header - return503OnClosing: false, skip Node < v19.x
         1..4
         ok 1 - should not error
         not ok 2 - should match pattern provided
           ---
           diff: |
             --- expected
             +++ actual
             @@ -1,1 +1,10 @@
             -/Connection:\s*keep-alive/i
             +String(
             +  HTTP/1.1 400 Bad Request\r
             +  Connection: close\r
             +  Date: Tue, 24 Jan 2023 14:13:48 GMT\r
             +  Transfer-Encoding: chunked\r
             +  \r
             +  0\r
             +  \r
             +  
             +)
           pattern: !re /Connection:\s*keep-alive/i
           at:
             line: 275
             column: 11
             file: test/close.test.js
             type: Socket
           stack: |
             Socket.<anonymous> (test/close.test.js:275:11)
           source: |2
                   client.once('data', data => {
                     t.match(data.toString(), /Connection:\s*keep-alive/i)
             ----------^
                     t.match(data.toString(), /200 OK/i)
           ...
         
         not ok 3 - should match pattern provided
           ---
           diff: |
             --- expected
             +++ actual
             @@ -1,1 +1,10 @@
             -/200 OK/i
             +String(
             +  HTTP/1.1 400 Bad Request\r
             +  Connection: close\r
             +  Date: Tue, 24 Jan 2023 14:13:48 GMT\r
             +  Transfer-Encoding: chunked\r
             +  \r
             +  0\r
             +  \r
             +  
             +)
           pattern: !re /200 OK/i
           at:
             line: 276
             column: 11
             file: test/close.test.js
             type: Socket
           stack: |
             Socket.<anonymous> (test/close.test.js:276:11)
           source: |2
                     t.match(data.toString(), /Connection:\s*keep-alive/i)
                     t.match(data.toString(), /200 OK/i)
             ----------^
           
                     client.write('GET / HTTP/1.1\r\n\r\n')
           ...
         
         ok 4 - close
         # failed 2 of 4 tests
     not ok 10 - Current opened connection should NOT continue to work after closing and return "connection: close" header - return503OnClosing: false, skip Node < v19.x # time=190.413ms

Undici:

 # Subtest: test/abort-controller.js
     1..0 # no tests found
 not ok 1 - test/abort-controller.js # time=149.983ms
   ---
   env: {}
   file: test/abort-controller.js
   timeout: 60000
   command: /home/iojs/build/workspace/citgm-smoker/smoker/bin/node
   args:
     - --expose-gc
     - --experimental-wasm-simd
     - test/abort-controller.js
   stdio:
     - 0
     - pipe
     - 2
   cwd: /home/iojs/tmp/citgm_tmp/5a4a14ca-e0e8-4e87-8f27-1efecbd6d768/undici
   exitCode: 9
   ...
 # Subtest: test/abort-event-emitter.js
     1..0 # no tests found
 not ok 2 - test/abort-event-emitter.js # time=187.344ms
   ---
   env: {}
   file: test/abort-event-emitter.js
   timeout: 60000
   command: /home/iojs/build/workspace/citgm-smoker/smoker/bin/node
   args:
     - --expose-gc
     - --experimental-wasm-simd
     - test/abort-event-emitter.js
   stdio:
     - 0
     - pipe
     - 2
   cwd: /home/iojs/tmp/citgm_tmp/5a4a14ca-e0e8-4e87-8f27-1efecbd6d768/undici
   exitCode: 9
   ...

That Undici failure doesn't appear obviously connected to this change. It's complaining no tests found during some AbortController testing, without appearing to touch the Connection header anywhere. I'm not sure how CITGM works, but does that same test definitely pass reliably without this PR?

The Fastify one certainly seems related though, I'll dig into it.

The Fastify issue appears unrelated. That test does fail for me locally, but fails in exactly the same way on the preceding main commit, without this PR.

I did some digging, the failure there comes from an unexpected 400 error that was added by this commit. You can see in the test that they're manually constructing a test HTTP request, without including a Host header, and so it's now being (correctly) rejected by Node after that change.

That's nothing to do with this change (and it's reasonable semver-major breakage imo - their test suite is sending an invalid HTTP request and it really should fail).

I checked on Undici too, just in case. Those tests pass locally for me using this code, and I can't see any relationship between them and these changes, so I think it's likely that that failure is some kind of intermittent or otherwise unrelated issue.

sgtm, this can land

CI: https://ci.nodejs.org/job/node-test-pull-request/49234/

Landed in 2a29df6

Notable Changes: crypto: * (SEMVER-MAJOR) use WebIDL converters in WebCryptoAPI (Filip Skokan) #46067 deps: * update ada to 2.0.0 (Node.js GitHub Bot) #47339 src,process: * (SEMVER-MINOR) add permission model (Rafael Gonzaga) #44004 url: * drop ICU requirement for parsing hostnames (Yagiz Nizipli) #47339 * use ada::url_aggregator for parsing urls (Yagiz Nizipli) #47339 * (SEMVER-MAJOR) runtime-deprecate url.parse() with invalid ports (Rich Trott) #45526 Semver-Major Commits: * [9fafb0a] - (SEMVER-MAJOR) async_hooks: deprecate the AsyncResource.bind asyncResource property (James M Snell) #46432 * [1948d37] - (SEMVER-MAJOR) buffer: check INSPECT_MAX_BYTES with validateNumber (Umuoy) #46599 * [7bc0e6a] - (SEMVER-MAJOR) buffer: graduate File from experimental and expose as global (Khafra) #47153 * [671ffd7] - (SEMVER-MAJOR) buffer: use min/max of `validateNumber` (Deokjin Kim) #45796 * [ab1614d] - (SEMVER-MAJOR) build: reset embedder string to "-node.0" (Michaël Zasso) #47251 * [c1bcdbc] - (SEMVER-MAJOR) build: warn for gcc versions earlier than 10.1 (Richard Lau) #46806 * [649f68f] - (SEMVER-MAJOR) build: reset embedder string to "-node.0" (Yagiz Nizipli) #45579 * [9374700] - (SEMVER-MAJOR) crypto: remove DEFAULT_ENCODING (Tobias Nießen) #47182 * [1640aeb] - (SEMVER-MAJOR) crypto: remove obsolete SSL_OP_* constants (Tobias Nießen) #47073 * [c2e4b1f] - (SEMVER-MAJOR) crypto: remove ALPN_ENABLED (Tobias Nießen) #47028 * [3ef38c4] - (SEMVER-MAJOR) crypto: use WebIDL converters in WebCryptoAPI (Filip Skokan) #46067 * [08af023] - (SEMVER-MAJOR) crypto: runtime deprecate replaced rsa-pss keygen parameters (Filip Skokan) #45653 * [7eb0ac3] - (SEMVER-MAJOR) deps: patch V8 to support compilation on win-arm64 (Michaël Zasso) #47251 * [a7c129f] - (SEMVER-MAJOR) deps: silence irrelevant V8 warning (Michaël Zasso) #47251 * [6f5655a] - (SEMVER-MAJOR) deps: always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #47251 * [f226350] - (SEMVER-MAJOR) deps: update V8 to 11.3.244.4 (Michaël Zasso) #47251 * [d6dae74] - (SEMVER-MAJOR) deps: V8: cherry-pick f1c888e7093e (Michaël Zasso) #45579 * [56c4365] - (SEMVER-MAJOR) deps: fix V8 build on Windows with MSVC (Michaël Zasso) #45579 * [51ab98c] - (SEMVER-MAJOR) deps: silence irrelevant V8 warning (Michaël Zasso) #45579 * [9f84d3e] - (SEMVER-MAJOR) deps: V8: fix v8-cppgc.h for MSVC (Jiawen Geng) #45579 * [f2318cd] - (SEMVER-MAJOR) deps: fix V8 build issue with inline methods (Jiawen Geng) #45579 * [16e03e7] - (SEMVER-MAJOR) deps: update V8 to 10.9.194.4 (Yagiz Nizipli) #45579 * [6473f5e] - (SEMVER-MAJOR) doc: update toolchains used for Node.js 20 releases (Richard Lau) #47352 * [cc18fd9] - (SEMVER-MAJOR) events: refactor to use `validateNumber` (Deokjin Kim) #45770 * [ff92b40] - (SEMVER-MAJOR) http: close the connection after sending a body without declared length (Tim Perry) #46333 * [2a29df6] - (SEMVER-MAJOR) http: keep HTTP/1.1 conns alive even if the Connection header is removed (Tim Perry) #46331 * [391dc74] - (SEMVER-MAJOR) http: throw error if options of http.Server is array (Deokjin Kim) #46283 * [ed3604c] - (SEMVER-MAJOR) http: server check Host header, to meet RFC 7230 5.4 requirement (wwwzbwcom) #45597 * [4b08c4c] - (SEMVER-MAJOR) lib: runtime deprecate punycode (Yagiz Nizipli) #47202 * [88d71dc] - (SEMVER-MAJOR) lib: refactor to use min/max of `validateNumber` (Deokjin Kim) #45772 * [e4d641f] - (SEMVER-MAJOR) lib: refactor to use validators in http2 (Debadree Chatterjee) #46174 * [0f3e531] - (SEMVER-MAJOR) lib: performance improvement on readline async iterator (Thiago Oliveira Santos) #41276 * [5b5898a] - (SEMVER-MAJOR) lib,src: update exit codes as per todos (Debadree Chatterjee) #45841 * [8b51c1a] - (SEMVER-MAJOR) net: enable autoSelectFamily by default (Paolo Insogna) #46790 * [2d0d997] - (SEMVER-MAJOR) process: remove `process.exit()`, `process.exitCode` coercion to integer (Daeyeon Jeong) #43716 * [dc06df3] - (SEMVER-MAJOR) readline: refactor to use `validateNumber` (Deokjin Kim) #45801 * [295b2f3] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 115 (Michaël Zasso) #47251 * [3803b02] - (SEMVER-MAJOR) src: share common code paths for SEA and embedder script (Anna Henningsen) #46825 * [e8bddac] - (SEMVER-MAJOR) src: apply ABI-breaking API simplifications (Anna Henningsen) #46705 * [f84de0a] - (SEMVER-MAJOR) src: use uint32_t for process initialization flags enum (Anna Henningsen) #46427 * [a624277] - (SEMVER-MAJOR) src: fix ArrayBuffer::Detach deprecation (Michaël Zasso) #45579 * [dd5c39a] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 112 (Yagiz Nizipli) #45579 * [63eca7f] - (SEMVER-MAJOR) stream: validate readable defaultEncoding (Marco Ippolito) #46430 * [9e7093f] - (SEMVER-MAJOR) stream: validate writable defaultEncoding (Marco Ippolito) #46322 * [fb91ee4] - (SEMVER-MAJOR) test: make trace-gc-flag tests less strict (Yagiz Nizipli) #45579 * [eca6180] - (SEMVER-MAJOR) test: adapt test-v8-stats for V8 update (Michaël Zasso) #45579 * [c03354d] - (SEMVER-MAJOR) test: test case for multiple res.writeHead and res.getHeader (Marco Ippolito) #45508 * [c733cc0] - (SEMVER-MAJOR) test_runner: mark module as stable (Colin Ihrig) #46983 * [7ce2232] - (SEMVER-MAJOR) tools: update V8 gypfiles for 11.1 (Michaël Zasso) #47251 * [ca4bd30] - (SEMVER-MAJOR) tools: update V8 gypfiles for 11.0 (Michaël Zasso) #47251 * [58b06a2] - (SEMVER-MAJOR) tools: update V8 gypfiles (Michaël Zasso) #45579 * [027841c] - (SEMVER-MAJOR) url: use private properties for brand check (Yagiz Nizipli) #46904 * [3bed5f1] - (SEMVER-MAJOR) url: runtime-deprecate url.parse() with invalid ports (Rich Trott) #45526 * [7c76fdd] - (SEMVER-MAJOR) util,doc: mark parseArgs() as stable (Colin Ihrig) #46718 * [7efae93] - (SEMVER-MAJOR) wasi: make version non-optional (Michael Dawson) #47391 Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #47441

Notable Changes: crypto: * (SEMVER-MAJOR) use WebIDL converters in WebCryptoAPI (Filip Skokan) #46067 deps: * update ada to 2.0.0 (Node.js GitHub Bot) #47339 esm: * move hook execution to separate thread (Jacob Smith) #44710 sea: * use JSON configuration and blob content for SEA (Joyee Cheung) #47125 src,process: * (SEMVER-MINOR) add permission model (Rafael Gonzaga) #44004 url: * drop ICU requirement for parsing hostnames (Yagiz Nizipli) #47339 * use ada::url_aggregator for parsing urls (Yagiz Nizipli) #47339 * (SEMVER-MAJOR) runtime-deprecate url.parse() with invalid ports (Rich Trott) #45526 Semver-Major Commits: * [9fafb0a] - (SEMVER-MAJOR) async_hooks: deprecate the AsyncResource.bind asyncResource property (James M Snell) #46432 * [1948d37] - (SEMVER-MAJOR) buffer: check INSPECT_MAX_BYTES with validateNumber (Umuoy) #46599 * [7bc0e6a] - (SEMVER-MAJOR) buffer: graduate File from experimental and expose as global (Khafra) #47153 * [671ffd7] - (SEMVER-MAJOR) buffer: use min/max of `validateNumber` (Deokjin Kim) #45796 * [ab1614d] - (SEMVER-MAJOR) build: reset embedder string to "-node.0" (Michaël Zasso) #47251 * [c1bcdbc] - (SEMVER-MAJOR) build: warn for gcc versions earlier than 10.1 (Richard Lau) #46806 * [649f68f] - (SEMVER-MAJOR) build: reset embedder string to "-node.0" (Yagiz Nizipli) #45579 * [9374700] - (SEMVER-MAJOR) crypto: remove DEFAULT_ENCODING (Tobias Nießen) #47182 * [1640aeb] - (SEMVER-MAJOR) crypto: remove obsolete SSL_OP_* constants (Tobias Nießen) #47073 * [c2e4b1f] - (SEMVER-MAJOR) crypto: remove ALPN_ENABLED (Tobias Nießen) #47028 * [3ef38c4] - (SEMVER-MAJOR) crypto: use WebIDL converters in WebCryptoAPI (Filip Skokan) #46067 * [08af023] - (SEMVER-MAJOR) crypto: runtime deprecate replaced rsa-pss keygen parameters (Filip Skokan) #45653 * [7eb0ac3] - (SEMVER-MAJOR) deps: patch V8 to support compilation on win-arm64 (Michaël Zasso) #47251 * [a7c129f] - (SEMVER-MAJOR) deps: silence irrelevant V8 warning (Michaël Zasso) #47251 * [6f5655a] - (SEMVER-MAJOR) deps: always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #47251 * [f226350] - (SEMVER-MAJOR) deps: update V8 to 11.3.244.4 (Michaël Zasso) #47251 * [d6dae74] - (SEMVER-MAJOR) deps: V8: cherry-pick f1c888e7093e (Michaël Zasso) #45579 * [56c4365] - (SEMVER-MAJOR) deps: fix V8 build on Windows with MSVC (Michaël Zasso) #45579 * [51ab98c] - (SEMVER-MAJOR) deps: silence irrelevant V8 warning (Michaël Zasso) #45579 * [9f84d3e] - (SEMVER-MAJOR) deps: V8: fix v8-cppgc.h for MSVC (Jiawen Geng) #45579 * [f2318cd] - (SEMVER-MAJOR) deps: fix V8 build issue with inline methods (Jiawen Geng) #45579 * [16e03e7] - (SEMVER-MAJOR) deps: update V8 to 10.9.194.4 (Yagiz Nizipli) #45579 * [6473f5e] - (SEMVER-MAJOR) doc: update toolchains used for Node.js 20 releases (Richard Lau) #47352 * [cc18fd9] - (SEMVER-MAJOR) events: refactor to use `validateNumber` (Deokjin Kim) #45770 * [ff92b40] - (SEMVER-MAJOR) http: close the connection after sending a body without declared length (Tim Perry) #46333 * [2a29df6] - (SEMVER-MAJOR) http: keep HTTP/1.1 conns alive even if the Connection header is removed (Tim Perry) #46331 * [391dc74] - (SEMVER-MAJOR) http: throw error if options of http.Server is array (Deokjin Kim) #46283 * [ed3604c] - (SEMVER-MAJOR) http: server check Host header, to meet RFC 7230 5.4 requirement (wwwzbwcom) #45597 * [88d71dc] - (SEMVER-MAJOR) lib: refactor to use min/max of `validateNumber` (Deokjin Kim) #45772 * [e4d641f] - (SEMVER-MAJOR) lib: refactor to use validators in http2 (Debadree Chatterjee) #46174 * [0f3e531] - (SEMVER-MAJOR) lib: performance improvement on readline async iterator (Thiago Oliveira Santos) #41276 * [5b5898a] - (SEMVER-MAJOR) lib,src: update exit codes as per todos (Debadree Chatterjee) #45841 * [55321ba] - (SEMVER-MAJOR) net: enable autoSelectFamily by default (Paolo Insogna) #46790 * [2d0d997] - (SEMVER-MAJOR) process: remove `process.exit()`, `process.exitCode` coercion to integer (Daeyeon Jeong) #43716 * [dc06df3] - (SEMVER-MAJOR) readline: refactor to use `validateNumber` (Deokjin Kim) #45801 * [295b2f3] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 115 (Michaël Zasso) #47251 * [3803b02] - (SEMVER-MAJOR) src: share common code paths for SEA and embedder script (Anna Henningsen) #46825 * [e8bddac] - (SEMVER-MAJOR) src: apply ABI-breaking API simplifications (Anna Henningsen) #46705 * [f84de0a] - (SEMVER-MAJOR) src: use uint32_t for process initialization flags enum (Anna Henningsen) #46427 * [a624277] - (SEMVER-MAJOR) src: fix ArrayBuffer::Detach deprecation (Michaël Zasso) #45579 * [dd5c39a] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 112 (Yagiz Nizipli) #45579 * [63eca7f] - (SEMVER-MAJOR) stream: validate readable defaultEncoding (Marco Ippolito) #46430 * [9e7093f] - (SEMVER-MAJOR) stream: validate writable defaultEncoding (Marco Ippolito) #46322 * [fb91ee4] - (SEMVER-MAJOR) test: make trace-gc-flag tests less strict (Yagiz Nizipli) #45579 * [eca6180] - (SEMVER-MAJOR) test: adapt test-v8-stats for V8 update (Michaël Zasso) #45579 * [c03354d] - (SEMVER-MAJOR) test: test case for multiple res.writeHead and res.getHeader (Marco Ippolito) #45508 * [c733cc0] - (SEMVER-MAJOR) test_runner: mark module as stable (Colin Ihrig) #46983 * [7ce2232] - (SEMVER-MAJOR) tools: update V8 gypfiles for 11.1 (Michaël Zasso) #47251 * [ca4bd30] - (SEMVER-MAJOR) tools: update V8 gypfiles for 11.0 (Michaël Zasso) #47251 * [58b06a2] - (SEMVER-MAJOR) tools: update V8 gypfiles (Michaël Zasso) #45579 * [027841c] - (SEMVER-MAJOR) url: use private properties for brand check (Yagiz Nizipli) #46904 * [3bed5f1] - (SEMVER-MAJOR) url: runtime-deprecate url.parse() with invalid ports (Rich Trott) #45526 * [7c76fdd] - (SEMVER-MAJOR) util,doc: mark parseArgs() as stable (Colin Ihrig) #46718 * [4b52727] - (SEMVER-MAJOR) wasi: make version non-optional (Michael Dawson) #47391 Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #47441 Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>

Previously persistence was completed disabled if you removed this header, which is not correct for modern HTTP, where the header is optional and all connections should persist by default regardless. PR-URL: nodejs#46331 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

Previously persistence was completed disabled if you removed this header, which is not correct for modern HTTP, where the header is optional and all connections should persist by default regardless. PR-URL: #46331 Backport-PR-URL: #49016 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

Sorry for the noise in here but for a brief moment a commit from this PR landed (9c0de7d) in the v18.x-staging branch as it was part of a larger backport PR. I noticed (after landing the commit) the semver-major label and have then removed 9c0de7d from v18.x-staging.

http: keep HTTP/1.1 conns alive even if the Connection header is removed

3944b7f

Previously persistence was completed disabled if you removed this header, which is not correct for modern HTTP, where the header is optional and all connections should persist by default regardless.

nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Jan 24, 2023

pimterry mentioned this pull request Jan 24, 2023

Incorrect HTTP keep-alive default when Connection header is removed #46321

Closed

richardlau added the needs-citgm PRs that need a CITGM CI run. label Jan 24, 2023

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 24, 2023

mcollina approved these changes Jan 24, 2023

View reviewed changes

mcollina reviewed Jan 24, 2023

View reviewed changes

Comment thread test/parallel/test-http-remove-connection-header-persists-connection.js Outdated

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 24, 2023

Remove unnecessary copyright header from test file

66e6405

pimterry mentioned this pull request Jan 24, 2023

http: close the connection after sending a body without declared length #46333

Merged

mcollina added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jan 24, 2023

pimterry mentioned this pull request Jan 24, 2023

Mockttp is not working with Node.js 19 / Wrong connection header handling httptoolkit/mockttp#107

Closed

VoltrexKeyva reviewed Jan 24, 2023

View reviewed changes

Comment thread lib/_http_outgoing.js Outdated

Simplify no-header connection keep-alive logic

a57bbef

Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

JungMinu approved these changes Jan 26, 2023

View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 26, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 26, 2023

jasnell approved these changes Jan 29, 2023

View reviewed changes

mcollina added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed needs-ci PRs that need a full CI run. labels Jan 29, 2023

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 29, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 29, 2023

rickyes approved these changes Jan 30, 2023

View reviewed changes

mcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 30, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 30, 2023

nodejs-github-bot merged commit 2a29df6 into nodejs:main Jan 30, 2023

RafaelGSS mentioned this pull request Apr 3, 2023

2023-04-18, Version 20.0.0 (Current) #47381

Merged

pimterry mentioned this pull request May 26, 2023

[Bug]: Sending two requests with the rust library reqwest makes the second fail httptoolkit/httptoolkit#425

Closed

pimterry deleted the http-default-keep-alive branch May 30, 2023 14:18

glasser mentioned this pull request Jul 21, 2023

Test against Node 20, update tests for compatibility apollographql/apollo-server#7636

Merged

mhdawson mentioned this pull request Aug 4, 2023

[v18.x] Backport 48969 to v18.x staging #49016

Closed

ti2sugiyama mentioned this pull request Nov 22, 2023

Warning "Jest did not exit one second after the test run has completed" out on Node v20 shelfio/jest-dynamodb#223

Open

garg3133 mentioned this pull request Dec 11, 2023

Fix process stalling for 4 mins after test run in Node v20+. nightwatchjs/nightwatch#3976

Merged

http: keep HTTP/1.1 conns alive even if the Connection header is removed by pimterry · Pull Request #46331 · nodejs/node · GitHub

Uh oh!

Uh oh!

http: keep HTTP/1.1 conns alive even if the Connection header is removed - #46331

http: keep HTTP/1.1 conns alive even if the Connection header is removed#46331nodejs-github-bot merged 3 commits intonodejs:mainnodejs/node:mainfrom pimterry:http-default-keep-alivepimterry/node:http-default-keep-aliveCopy head branch name to clipboard

Conversation

pimterry commented Jan 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 24, 2023

Uh oh!

ShogunPanda commented Jan 24, 2023

Uh oh!

mcollina commented Jan 24, 2023

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 24, 2023

Uh oh!

Uh oh!

mcollina commented Jan 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pimterry commented Jan 26, 2023

Uh oh!

pimterry commented Jan 26, 2023

Uh oh!

mcollina commented Jan 26, 2023

Uh oh!

nodejs-github-bot commented Jan 29, 2023

Uh oh!

nodejs-github-bot commented Jan 30, 2023

Uh oh!

ruyadorno commented Aug 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

http: keep HTTP/1.1 conns alive even if the Connection header is removed#46331
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
pimterry:http-default-keep-alive

pimterry commented Jan 24, 2023 •
edited
Loading

mcollina commented Jan 26, 2023 •
edited
Loading