FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix test-permission-deny-fs-wildcard (win32) by tniessen · Pull Request #47095 · nodejs/node · GitHub

/ node Public

test: fix test-permission-deny-fs-wildcard (win32) - #47095

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:test-fix-permission-deny-fs-wildcard-windows
Mar 15, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: fix test-permission-deny-fs-wildcard (win32)#47095
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:test-fix-permission-deny-fs-wildcard-windows

Conversation

tniessen commented Mar 14, 2023

Copy link
Copy Markdown
Member

The test fails on Windows when the working directory is not on a 'C:' drive. For example, it always fails during the coverage-windows GitHub action, which runs tests on drive 'D:'.

Fixes: #47093

test: fix test-permission-deny-fs-wildcard (win32)
0e42c4c 
The test fails on Windows when the working directory is not on a 'C:'
drive. For example, it always fails during the coverage-windows GitHub
action, which runs tests on drive 'D:'.

Fixes: nodejs#47093
tniessen requested a review from RafaelGSS March 14, 2023 19:46
nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 14, 2023
RafaelGSS approved these changes Mar 14, 2023
View reviewed changes

RafaelGSS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Thank you.

RafaelGSS commented Mar 14, 2023

Copy link
Copy Markdown
Member

Does it need fast-track?

tniessen commented Mar 14, 2023

Copy link
Copy Markdown
Member Author

Does it need fast-track?

I don't think that's strictly necessary; while the test fails during coverage-windows, the coverage jobs seem to ignore test outcomes, and Jenkins uses the C: drive for tests, so it's not blocking anything :)

richardlau mentioned this pull request Mar 14, 2023
Merged

richardlau commented Mar 14, 2023

Copy link
Copy Markdown
Member

Does it need fast-track?

I don't think that's strictly necessary; while the test fails during coverage-windows, the coverage jobs seem to ignore test outcomes, and Jenkins uses the C: drive for tests, so it's not blocking anything :)

Not sure if this is the cause of this test failing on the Windows on arm64 CI: #47020

tniessen added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 14, 2023

github-actions Bot commented Mar 14, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

tniessen commented Mar 14, 2023

Copy link
Copy Markdown
Member Author

@richardlau I don't know either, but I'll propose fast-tracking and we'll see.

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 14, 2023

nodejs-github-bot commented Mar 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50381/

tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 15, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 15, 2023
nodejs-github-bot merged commit 1cfe058 into nodejs:main Mar 15, 2023

nodejs-github-bot commented Mar 15, 2023

Copy link
Copy Markdown
Collaborator

Landed in 1cfe058

RafaelGSS mentioned this pull request Apr 3, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
anonrig anonrig approved these changes
cjihrig cjihrig approved these changes
MoLow MoLow approved these changes
RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test-permission-deny-fs-wildcard always fails during coverage-windows GitHub action

9 participants

Back | FazBrowse Home | New Git URL