quic: add more quic implementation details (part 3) - #47348
Closed
jasnell wants to merge 4 commits into
Closed
Conversation
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
This comment was marked as outdated.
anonrig
reviewed
Mar 31, 2023
Comment thread
src/quic/defs.h
Outdated
Comment thread
src/quic/defs.h
Outdated
Comment thread
src/quic/logstream.h
Outdated
Comment thread
src/quic/transportparams.h
Outdated
anonrig
reviewed
Mar 31, 2023
Comment thread
src/quic/defs.h
Outdated
anonrig
approved these changes
Mar 31, 2023
This comment was marked as outdated.
30 tasks
Qard
approved these changes
Apr 2, 2023
This was referenced Apr 3, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Qard
approved these changes
Apr 9, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Copy link
Copy Markdown
Member
Author
|
Ugh. Not sure why test-child-process-can-write-to-stdout is failing consistently on Mac here. |
Sorry, something went wrong.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/51112/ 💚 finally! |
Sorry, something went wrong.
jasnell
added a commit
that referenced
this pull request
Apr 10, 2023
* add BindingData * add LogStream * add TransportParams PR-URL: #47348 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
This was referenced Apr 12, 2023
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 13, 2023
* add BindingData * add LogStream * add TransportParams PR-URL: #47348 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
* add BindingData * add LogStream * add TransportParams PR-URL: #47348 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
* add BindingData * add LogStream * add TransportParams PR-URL: nodejs#47348 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.