bootstrap: fix wasm_web_api external reference registration · nodejs/node@9ee7d9e · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 9ee7d9e

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

RafaelGSS

committed

bootstrap: fix wasm_web_api external reference registration

The external references were not actually registered. PR-URL: #42903 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

1 parent e74a8da commit 9ee7d9e
Copy full SHA for 9ee7d9e

2 files changed

+4Lines changed: 4 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_external_reference.h
  • node_wasm_web_api.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_external_reference.h‎

Copy file name to clipboardExpand all lines: src/node_external_reference.h

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -90,6 +90,7 @@ class ExternalReferenceRegistry {
90	90	V(uv) \
91	91	V(v8) \
92	92	V(zlib) \
	93	+ V(wasm_web_api) \
93	94	V(worker)
94	95
95	96	#if NODE_HAVE_I18N_SUPPORT

Collapse file

‎src/node_wasm_web_api.cc‎

Copy file name to clipboardExpand all lines: src/node_wasm_web_api.cc

+3Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -41,6 +41,7 @@ Local<Function> WasmStreamingObject::Initialize(Environment* env) {
41	41
42	42	void WasmStreamingObject::RegisterExternalReferences(
43	43	ExternalReferenceRegistry* registry) {
	44	+ registry->Register(New);
44	45	registry->Register(Push);
45	46	registry->Register(Finish);
46	47	registry->Register(Abort);
@@ -198,6 +199,8 @@ void Initialize(Local<Object> target,
198	199
199	200	void RegisterExternalReferences(ExternalReferenceRegistry* registry) {
200	201	registry->Register(SetImplementation);
	202	+ registry->Register(StartStreamingCompilation);
	203	+ WasmStreamingObject::RegisterExternalReferences(registry);
201	204	}
202	205
203	206	} // namespace wasm_web_api

0 commit comments

Comments

0 (0)