bootstrap: fix wasm_web_api external reference registration - #42903
Merged
nodejs-github-bot merged 1 commit intoMay 2, 2022
Merged
bootstrap: fix wasm_web_api external reference registration#42903nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The external references were not actually registered.
tniessen
approved these changes
Apr 29, 2022
tniessen
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thank you!
Sorry, something went wrong.
aduh95
approved these changes
Apr 29, 2022
This comment was marked as outdated.
VoltrexKeyva
approved these changes
Apr 29, 2022
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Apr 30, 2022
addaleax
approved these changes
May 2, 2022
This was referenced May 3, 2022
RafaelGSS
pushed a commit
that referenced
this pull request
May 10, 2022
The external references were not actually registered. PR-URL: #42903 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The external references were not actually registered.