v18.2.0 proposal by RafaelGSS · Pull Request #43036 · nodejs/node · GitHub

2022-05-17, Version 18.2.0 (Current), @BethGriggs prepared by @RafaelGSS

Notable Changes

OpenSSL 3.0.3

This update can be treated as a security release as the issues addressed in OpenSSL 3.0.3 slightly affect Node.js 18.
See https://nodejs.org/en/blog/vulnerability/openssl-fixes-in-regular-releases-may2022/ for more information on how the May 2022 OpenSSL releases affect other Node.js release lines.

[8e54c19a6e] - deps: update archs files for quictls/openssl-3.0.3+quic (RafaelGSS) #43022
[6365bf808e] - deps: upgrade openssl sources to quictls/openssl-3.0.3 (RafaelGSS) #43022

Other Notable Changes

[13c333e533] - Revert "deps: add template for generated headers" (Daniel Bevenius) #42978
[d128356a7f] - deps: update undici to 5.2.0 (Node.js GitHub Bot) #43059
[2df1624f80] - deps: upgrade npm to 8.9.0 (npm team) #42968
[6365bf808e] - deps: upgrade openssl sources to quictls/openssl-3.0.3 (RafaelGSS) #43022
[4a3f678e70] - doc: add LiviaMedeiros to collaborators (LiviaMedeiros) #43039
[686c4c1f6f] - doc: add release key for Juan Arboleda (Juan José) #42961
[784d84cf34] - (SEMVER-MINOR) fs: add read(buffer[, options]) versions (LiviaMedeiros) #42768
[2f192c4be0] - (SEMVER-MINOR) http: added connection closing methods (Paolo Insogna) #42812
[c92e291beb] - perf_hooks: add PerformanceResourceTiming (RafaelGSS) #42725

Commits

[7cac7bb806] - assert: fix CallTracker wraps the function causes the length to be lost (OneNail) #42909
[e74a8da287] - assert: make assert.fail less affected by prototype tampering (Antoine du Hamel) #42918
[1146806673] - bootstrap: stop delaying instantiation of maps in per-context scripts (Darshan Sen) #42934
[a20310d171] - bootstrap: use a context snapshotted with primordials in workers (Joyee Cheung) #42867
[9ee7d9eb15] - bootstrap: fix wasm_web_api external reference registration (Joyee Cheung) #42903
[cec678a00e] - build: set ASAN workaround (Richard Lau) #43085
[7c4df42caa] - build: disable windows-2022 temporarily (Jiawen Geng) #43093
[0eb32ed976] - build: fix various shared library build issues (William Marlow) #41850
[48f4a714b2] - build: fix indeterminacy of icu_locales value (Sergey Nazaryev) #42865
[19c060fd84] - crypto: adjust minimum length in generateKey('hmac', ...) (LiviaMedeiros) #42944
[183bcc0699] - crypto: clean up parameter validation in HKDF (Tobias Nießen) #42924
[946f57c7bc] - debugger: fix inconsistent inspector output of exec new Map() (Kohei Ueno) #42423
[d128356a7f] - deps: update undici to 5.2.0 (Node.js GitHub Bot) #43059
[a9703a55ef] - deps: remove opensslconf template headers (Daniel Bevenius) #43035
[a4a4f7134b] - deps: fix llhttp version number (Michael Dawson) #43029
[8e54c19a6e] - deps: update archs files for quictls/openssl-3.0.3+quic (RafaelGSS) #43022
[6365bf808e] - deps: upgrade openssl sources to quictls/openssl-3.0.3 (RafaelGSS) #43022
[e8121ae7fe] - deps: regenerate OpenSSL archs files (Daniel Bevenius) #42978
[13c333e533] - Revert "deps: add template for generated headers" (Daniel Bevenius) #42978
[2df1624f80] - deps: upgrade npm to 8.9.0 (npm team) #42968
[f53ed9d1bb] - doc: use serial comma in fs docs (Tobias Nießen) #43104
[839824aca8] - doc: use serial comma in events docs (Tobias Nießen) #43113
[9629c74080] - doc: use serial comma in modules docs (Tobias Nießen) #43103
[76096c2d4a] - doc: use serial comma in util docs (Tobias Nießen) #43063
[1e9de0dd5a] - doc: remove git:// protocol, adjust nits in onboarding.md (LiviaMedeiros) #43045
[eb630d7ef9] - doc: add maintaining info for shared libary option (Michael Dawson) #42517
[3816a97bae] - doc: add detail for how to update llhttp (Michael Dawson) #43028
[330e267a57] - doc: use serial comma in buffer docs (Tobias Nießen) #43048
[0957212390] - doc: use consistent method symbol (Paolo Insogna) #42974
[22cb7104cb] - doc: add Rafael to the security steward for NearForm (Matteo Collina) #42966
[ef177da3f1] - doc: mark some node-api functions as experimental (NickNaso) #42987
[4a3f678e70] - doc: add LiviaMedeiros to collaborators (LiviaMedeiros) #43039
[c988a0ed26] - doc: use serial comma in http docs (Tobias Nießen) #43026
[4de918b4c1] - doc: add the preferred name for @himself65 (Himself65) #43024
[686c4c1f6f] - doc: add release key for Juan Arboleda (Juan José) #42961
[64e0aa116d] - doc: rename N-API to Node-API in test/README.md (Daeyeon Jeong) #42946
[65d64553c0] - doc: use serial comma in tls docs (Tobias Nießen) #43001
[840e61e745] - doc: improve commit message example for releases (Juan José) #42954
[ba3ad7c665] - doc: use serial comma in cluster docs (Tobias Nießen) #42989
[3ab3086008] - doc: fix errors in Web Streams doc (OneNail) #42862
[1fbfee2497] - doc: fix examples in cluster.md (OneNail) #42889
[1237c742f4] - doc: add additional step to security release process (Michael Dawson) #42916
[88692d8fd6] - doc: add section regarding property definition in primordials.md (Antoine du Hamel) #42921
[924670f3af] - doc: clarify some default values in fs.md (LiviaMedeiros) #42892
[becca06f9b] - fs: remove unnecessary ?? operator (Morgan Roderick) #43073
[784d84cf34] - (SEMVER-MINOR) fs: add read(buffer[, options]) versions (LiviaMedeiros) #42768
[2f192c4be0] - (SEMVER-MINOR) http: added connection closing methods (Paolo Insogna) #42812
[bfbf965eb0] - http2: compat support for array headers (OneNail) #42901
[46a44b3011] - lib: move WebAssembly Web API into separate file (Tobias Nießen) #42993
[c64b8d3282] - lib,test: enable wasm/webapi/empty-body WPT (Tobias Nießen) #42960
[ddd271ec2b] - meta: add mailmap entry for ShogunPanda (Paolo Insogna) #43094
[174ff972f0] - meta: update .mailmap for recent README name change (Rich Trott) #43027
[16df8ad7c3] - meta: update AUTHORS (Node.js GitHub Bot) #43004
[0ec32d0715] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #42937
[037ff3da6d] - node-api: explicitly set __cdecl for API functions (Vladimir Morozov) #42780
[e2462a2f98] - node-api: fix napi_get_all_property_names (Vladimir Morozov) #42463
[c92e291beb] - perf_hooks: add PerformanceResourceTiming (RafaelGSS) #42725
[c535db1195] - src: delete AllocatedBuffer (Darshan Sen) #43008
[5dc79298e1] - src: remove unnecessary comment (Kohei Ueno) #42952
[38e4c15534] - src: always signal V8 for intercepted properties (Michaël Zasso) #42963
[cacff07e75] - src: fix memory leak for v8.serialize (liuxingbaoyu) #42695
[8cfc18e4db] - src,crypto: remove uses of AllocatedBuffer from crypto_rsa.cc (Darshan Sen) #42852
[0670843b24] - test: fix dangerous .map in test/parallel/test-http-set-trailers.js (LiviaMedeiros) #43087
[9eb8bf1d26] - test: reduce flakiness of test-fs-read-position-validation.mjs (LiviaMedeiros) #42999
[41d2f6e8c5] - test: rename handlewrap.hasref tests (Daeyeon Jeong) #42754
[e058f47277] - test: improve observable ICU behaviour coverage (LiviaMedeiros) #42683
[d23debb4cb] - test: validate webstream encoder/decoder inspector (Yoshiki Kurihara) #42747
[b1c18edaa9] - test: usemustSucceed instead of mustCall with assert.ifError (MURAKAMI Masahiko) #42806
[2dc795687a] - test: improve lib/internal/webstreams/readablestream.js coverage (MURAKAMI Masahiko) #42823
[d746207dc2] - test: fix test-crypto-fips.js under shared OpenSSL (Vita Batrla) #42947
[56c47b5101] - test: use consistent timeouts (Paolo Insogna) #42893
[68ed3c88d9] - test: add test for position validation in fs.read() and fs.readSync() (LiviaMedeiros) #42837
[72b90fd5f5] - test: reduce impact of flaky HTTP server tests (Tobias Nießen) #42926
[531a0a9980] - tools: update lint-md-dependencies to rollup@2.73.0 (Node.js GitHub Bot) #43107
[64daaca46d] - tools: update eslint to 8.15.0 (Node.js GitHub Bot) #43005
[79872382ef] - tools: refactor lint-sh.js to esm module (Feng Yu) #42942
[265ecdfe07] - tools: update lint-md-dependencies (Node.js GitHub Bot) #43003
[e9e1f1e194] - typings: fix os.cpus invalid return type (Himself65) #43006
[55ef6e81cb] - wasm: add missing init reported by coverity (Michael Dawson) #42897
[5470578008] - worker: fix stream racing with terminate (Keyhan Vakil) #42874

Refs: #42741 PR-URL: #42926 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: #42892 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>

PR-URL: #42924 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

PR-URL: #42921 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>

PR-URL: #42918 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

The external references were not actually registered. PR-URL: #42903 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #42901 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

PR-URL: #42837 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

This adds the following: - `fs.read(fd, buffer[, options], callback)`. - `filehandle.read(buffer[, options])`. PR-URL: #42768 Refs: #42601 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #42916 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

When Buffer::New passes in existing data, it cannot be garbage collected in js synchronous execution. Fixes: #40828 Refs: #38300 PR-URL: #42695 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

PR-URL: #42889 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

PR-URL: #42862 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Fixes: #41578 PR-URL: #42812 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #42893 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Co-authored-by: Luigi Pinca <luigipinca@gmail.com>

Fixes: #42827 PR-URL: #42947 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <midawson@redhat.com>

Also affects generateKeySync('hmac', ...) PR-URL: #42944 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Refs: #39941 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42852 Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #42968 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

PR-URL: #42867 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: #42823 Refs: https://coverage.nodejs.org/coverage-3a6b975981092213/lib/internal/webstreams/readablestream.js.html#L421 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

PR-URL: #42806 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

PR-URL: #42747 Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/webstreams/encoding.js.html#L98 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: #42683 Refs: #42440 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

The linked issue, https://bugs.chromium.org/p/v8/issues/detail?id=6593, is marked as "Fixed", so I think we can revert this now. This reverts commit 08a9c4a. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42934 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=9187 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

`HandleWrap.isRefed()` was renamed to `hasRef()`. However, the filename of related TCs has not been reflected. Refs: f31a5ec34a PR-URL: #42754 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: #42701 Refs: nodejs/undici#1346 Refs: #42939 PR-URL: #42960 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

PR-URL: #42937 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>

`icu_locales` is generated by joining values from `set` data structure. However, `set` doesn't guarantee an order, so the result of `icu_locales` is not determined. For example, the result value could be 'en,root' or 'root,en'. This fix makes it deterministic. The main reason of this fix is to restore the reproducibility of the build because the value of `icu_locales` is embedded into `node` binary. PR-URL: #42865 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>

Refs: #11321 Refs: #17384 PR-URL: #42989 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

OpenSSL This update can be treated as a security release as the issues addressed in OpenSSL 3.0.3 slightly affect Node.js 18. See https://nodejs.org/en/blog/vulnerability/openssl-fixes-in-regular-releases-may2022/ for more information on how the May 2022 OpenSSL releases affect other Node.js release lines. * deps: update archs files for quictls/openssl-3.0.3+quic (RafaelGSS) #43022 * deps: upgrade openssl sources to quictls/openssl-3.0.3 (RafaelGSS) #43022 Other Notable Changes * *Revert*_ "deps: add template for generated headers" (Daniel Bevenius) #42978 * deps: update undici to 5.2.0 (Node.js GitHub Bot) #43059 * deps: upgrade npm to 8.9.0 (npm team) #42968 * (SEMVER-MINOR) fs: add `read(buffer[, options])` versions (LiviaMedeiros) #42768 * (SEMVER-MINOR) http: added connection closing methods (Shogun) #42812 * doc: add LiviaMedeiros to collaborators (LiviaMedeiros) #43039 * doc: add release key for Juan Arboleda (Juan José) #42961 * (SEMVER-MINOR) fs: add `read(buffer[, options])` versions (LiviaMedeiros) #42768 * (SEMVER-MINOR) http: added connection closing methods (Paolo Insogna) #42812 * perf_hooks: add PerformanceResourceTiming (RafaelGSS) #42725 PR-URL: #43036

Notable changes: OpenSSL 3.0.3 This update can be treated as a security release as the issues addressed in OpenSSL 3.0.3 slightly affect Node.js 18. See https://nodejs.org/en/blog/vulnerability/openssl-fixes-in-regular-releases-may2022/ for more information on how the May 2022 OpenSSL releases affect other Node.js release lines. - deps: update archs files for quictls/openssl-3.0.3+quic (RafaelGSS) #43022 - deps: upgrade openssl sources to quictls/openssl-3.0.3 (RafaelGSS) #43022 Other notable changes: - _Revert_ "deps: add template for generated headers" (Daniel Bevenius) #42978 - deps: update undici to 5.2.0 (Node.js GitHub Bot) #43059 - deps: upgrade npm to 8.9.0 (npm team) #42968 - (SEMVER-MINOR) fs: add `read(buffer[, options])` versions (LiviaMedeiros) #42768 - (SEMVER-MINOR) http: added connection closing methods (Shogun) #42812 - doc: add LiviaMedeiros to collaborators (LiviaMedeiros) #43039 - doc: add release key for Juan Arboleda (Juan José) #42961 - (SEMVER-MINOR) fs: add `read(buffer[, options])` versions (LiviaMedeiros) #42768 - (SEMVER-MINOR) http: added connection closing methods (Paolo Insogna) #42812 - (SEMVER-MINOR) perf_hooks: add PerformanceResourceTiming (RafaelGSS) #42725 PR-URL: #43036

CI: https://ci.nodejs.org/job/node-test-pull-request/44031/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/4678/ ✅
CITGM (v18.1.0): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2934/
CITGM (v18.2.0-proposal): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2935/

CI: https://ci.nodejs.org/job/node-test-pull-request/44033/ ✅

Release build on 1531ef1: https://ci-release.nodejs.org/job/iojs+release/8469/

PR-URL: #43036

Notable changes: OpenSSL 3.0.3 This update can be treated as a security release as the issues addressed in OpenSSL 3.0.3 slightly affect Node.js 18. See https://nodejs.org/en/blog/vulnerability/openssl-fixes-in-regular-releases-may2022/ for more information on how the May 2022 OpenSSL releases affect other Node.js release lines. - deps: update archs files for quictls/openssl-3.0.3+quic (RafaelGSS) #43022 - deps: upgrade openssl sources to quictls/openssl-3.0.3 (RafaelGSS) #43022 Other notable changes: - _Revert_ "deps: add template for generated headers" (Daniel Bevenius) #42978 - deps: update undici to 5.2.0 (Node.js GitHub Bot) #43059 - deps: upgrade npm to 8.9.0 (npm team) #42968 - (SEMVER-MINOR) fs: add `read(buffer[, options])` versions (LiviaMedeiros) #42768 - (SEMVER-MINOR) http: added connection closing methods (Shogun) #42812 - doc: add LiviaMedeiros to collaborators (LiviaMedeiros) #43039 - doc: add release key for Juan Arboleda (Juan José) #42961 - (SEMVER-MINOR) fs: add `read(buffer[, options])` versions (LiviaMedeiros) #42768 - (SEMVER-MINOR) http: added connection closing methods (Paolo Insogna) #42812 - (SEMVER-MINOR) perf_hooks: add PerformanceResourceTiming (RafaelGSS) #42725 PR-URL: #43036

Refs: nodejs/node#43036

tniessen and others added 30 commits May 10, 2022 09:13

test: reduce impact of flaky HTTP server tests

72b90fd

Refs: #42741 PR-URL: #42926 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

doc: clarify some default values in fs.md

924670f

PR-URL: #42892 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>

doc: add section regarding property definition in primordials.md

88692d8

PR-URL: #42921 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>

assert: make assert.fail less affected by prototype tampering

e74a8da

PR-URL: #42918 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

test: add test for position validation in fs.read() and fs.readSync()

68ed3c8

PR-URL: #42837 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

fs: add read(buffer[, options]) versions

784d84c

This adds the following: - `fs.read(fd, buffer[, options], callback)`. - `filehandle.read(buffer[, options])`. PR-URL: #42768 Refs: #42601 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

doc: add additional step to security release process

1237c74

Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #42916 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

doc: fix examples in cluster.md

1fbfee2

PR-URL: #42889 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

http: added connection closing methods

2f192c4

Fixes: #41578 PR-URL: #42812 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

test: use consistent timeouts

56c47b5

PR-URL: #42893 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Co-authored-by: Luigi Pinca <luigipinca@gmail.com>

test: fix test-crypto-fips.js under shared OpenSSL

d746207

Fixes: #42827 PR-URL: #42947 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <midawson@redhat.com>

crypto: adjust minimum length in generateKey('hmac', ...)

19c060f

Also affects generateKeySync('hmac', ...) PR-URL: #42944 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

src,crypto: remove uses of AllocatedBuffer from crypto_rsa.cc

8cfc18e

Refs: #39941 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42852 Reviewed-By: Anna Henningsen <anna@addaleax.net>

bootstrap: use a context snapshotted with primordials in workers

a20310d

PR-URL: #42867 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

test: usemustSucceed instead of mustCall with assert.ifError

b1c18ed

PR-URL: #42806 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

test: improve observable ICU behaviour coverage

e058f47

PR-URL: #42683 Refs: #42440 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

lib,test: enable wasm/webapi/empty-body WPT

c64b8d3

Refs: #42701 Refs: nodejs/undici#1346 Refs: #42939 PR-URL: #42960 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

meta: move one or more collaborators to emeritus

0ec32d0

PR-URL: #42937 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>

doc: use serial comma in cluster docs

ba3ad7c

Refs: #11321 Refs: #17384 PR-URL: #42989 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

RafaelGSS force-pushed the v18.2.0-proposal branch from 812ba02 to c437cf3 Compare May 16, 2022 12:00

BethGriggs reviewed May 16, 2022

View reviewed changes

Comment thread doc/changelogs/CHANGELOG_V18.md Outdated

Comment thread doc/changelogs/CHANGELOG_V18.md Outdated

Comment thread doc/changelogs/CHANGELOG_V18.md Outdated

Comment thread doc/changelogs/CHANGELOG_V18.md Outdated

Comment thread doc/changelogs/CHANGELOG_V18.md Outdated

RafaelGSS force-pushed the v18.2.0-proposal branch from c437cf3 to 2e84c93 Compare May 16, 2022 12:38

RafaelGSS requested a review from BethGriggs May 16, 2022 12:38

RafaelGSS force-pushed the v18.2.0-proposal branch from 2e84c93 to 6eb7ae6 Compare May 16, 2022 13:00

RafaelGSS force-pushed the v18.2.0-proposal branch from 6eb7ae6 to b7bc76c Compare May 16, 2022 13:03

BethGriggs reviewed May 16, 2022

View reviewed changes

Comment thread doc/changelogs/CHANGELOG_V18.md Outdated

BethGriggs reviewed May 16, 2022

View reviewed changes

Comment thread doc/changelogs/CHANGELOG_V18.md Outdated

RafaelGSS force-pushed the v18.2.0-proposal branch from b7bc76c to 1531ef1 Compare May 16, 2022 15:41

BethGriggs approved these changes May 16, 2022

View reviewed changes

github-actions Bot mentioned this pull request May 17, 2022

CI Reliability 2022-05-17 nodejs/reliability#280

Open

23 tasks

RafaelGSS merged commit 1531ef1 into v18.x May 17, 2022

RafaelGSS added a commit that referenced this pull request May 17, 2022

Working on v18.2.1

7596fbf

PR-URL: #43036

RafaelGSS added a commit to RafaelGSS/nodejs.org that referenced this pull request May 17, 2022

Blog: v18.2.0 release post

308d9eb

Refs: nodejs/node#43036

RafaelGSS mentioned this pull request May 17, 2022

Blog: v18.2.0 release post nodejs/nodejs.org#4605

Merged

RafaelGSS added a commit to nodejs/nodejs.org that referenced this pull request May 17, 2022

Blog: v18.2.0 release post (#4605 )

20237ec

Refs: nodejs/node#43036

BethGriggs deleted the v18.2.0-proposal branch May 17, 2022 16:05

v18.2.0 proposal by RafaelGSS · Pull Request #43036 · nodejs/node · GitHub

Uh oh!

Uh oh!

v18.2.0 proposal - #43036

v18.2.0 proposal#43036
RafaelGSS merged 81 commits into
v18.xfrom
v18.2.0-proposal

RafaelGSS commented May 10, 2022 •
edited by BethGriggs
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented May 16, 2022 •
edited by BethGriggs
Loading

Uh oh!

Uh oh!

nodejs-github-bot commented May 16, 2022 •
edited by BethGriggs
Loading

Uh oh!

Uh oh!

BethGriggs commented May 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

v18.2.0 proposal by RafaelGSS · Pull Request #43036 · nodejs/node · GitHub

Uh oh!

Uh oh!

v18.2.0 proposal - #43036

v18.2.0 proposal#43036RafaelGSS merged 81 commits intov18.xnodejs/node:v18.xfrom v18.2.0-proposalnodejs/node:v18.2.0-proposalCopy head branch name to clipboard

Conversation

RafaelGSS commented May 10, 2022 • edited by BethGriggs Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2022-05-17, Version 18.2.0 (Current), @BethGriggs prepared by @RafaelGSS

Notable Changes

OpenSSL 3.0.3

Other Notable Changes

Commits

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented May 16, 2022 • edited by BethGriggs Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented May 16, 2022 • edited by BethGriggs Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BethGriggs commented May 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

v18.2.0 proposal#43036
RafaelGSS merged 81 commits into
v18.xfrom
v18.2.0-proposal

RafaelGSS commented May 10, 2022 •
edited by BethGriggs
Loading

nodejs-github-bot commented May 16, 2022 •
edited by BethGriggs
Loading

nodejs-github-bot commented May 16, 2022 •
edited by BethGriggs
Loading