doc: use serial comma in util docs - #43063
Merged
nodejs-github-bot merged 1 commit intoMay 12, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Trott
approved these changes
May 12, 2022
VoltrexKeyva
approved these changes
May 12, 2022
Copy link
Copy Markdown
Member
Author
|
Fast-track action failed, presumably a GitHub error: 2022-05-12T00:28:46.4933267Z ##[group]Run gh pr comment 43063 --repo nodejs/node --body "$FAST_TRACK_MESSAGE"
2022-05-12T00:28:46.4933865Z �[36;1mgh pr comment 43063 --repo nodejs/node --body "$FAST_TRACK_MESSAGE"�[0m
2022-05-12T00:28:46.5503993Z shell: /usr/bin/bash -e {0}
2022-05-12T00:28:46.5504881Z env:
2022-05-12T00:28:46.5506415Z STALE_MESSAGE: This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.
2022-05-12T00:28:46.5508336Z FAST_TRACK_MESSAGE: Fast-track has been requested by @tniessen. Please 👍 to approve.
2022-05-12T00:28:46.5510126Z GITHUB_TOKEN: ***
2022-05-12T00:28:46.5510847Z ##[endgroup]
2022-05-12T00:28:46.9564878Z HTTP 500 (https://api.github.com/graphql)
2022-05-12T00:28:46.9587111Z ##[error]Process completed with exit code 1.
2022-05-12T00:28:46.9828084Z Cleaning up orphan processes
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @tniessen. Please 👍 to approve. |
Sorry, something went wrong.
RaisinTen
approved these changes
May 12, 2022
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/43063 ✔ Done loading data for nodejs/node/pull/43063 ----------------------------------- PR info ------------------------------------ Title doc: use serial comma in util docs (#43063) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:doc-serial-comma-util -> nodejs:master Labels util, doc, fast-track Commits 1 - doc: use serial comma in util docs Committers 1 - Tobias Nießen PR-URL: https://github.com/nodejs/node/pull/43063 Refs: https://github.com/nodejs/node/pull/11321 Refs: https://github.com/nodejs/node/pull/17384 Reviewed-By: Rich Trott Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43063 Refs: https://github.com/nodejs/node/pull/11321 Refs: https://github.com/nodejs/node/pull/17384 Reviewed-By: Rich Trott Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Darshan Sen -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 12 May 2022 00:28:34 GMT ✔ Approvals: 3 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/43063#pullrequestreview-970127656 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43063#pullrequestreview-970134049 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43063#pullrequestreview-971111627 ℹ This PR is being fast-tracked ✖ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2315851490 |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/43063 ✔ Done loading data for nodejs/node/pull/43063 ----------------------------------- PR info ------------------------------------ Title doc: use serial comma in util docs (#43063) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:doc-serial-comma-util -> nodejs:master Labels util, doc, fast-track Commits 1 - doc: use serial comma in util docs Committers 1 - Tobias Nießen PR-URL: https://github.com/nodejs/node/pull/43063 Refs: https://github.com/nodejs/node/pull/11321 Refs: https://github.com/nodejs/node/pull/17384 Reviewed-By: Rich Trott Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43063 Refs: https://github.com/nodejs/node/pull/11321 Refs: https://github.com/nodejs/node/pull/17384 Reviewed-By: Rich Trott Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Darshan Sen -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 12 May 2022 00:28:34 GMT ✔ Approvals: 3 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/43063#pullrequestreview-970127656 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43063#pullrequestreview-970134049 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43063#pullrequestreview-971111627 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least two collaborators' approvals (👍). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2316043100 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
The first failed fast-track GitHub Action seems to have messed things up... I am going to delete the second automated fast-track comment and see if that helps. |
Sorry, something went wrong.
Merged
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Refs: nodejs/node#11321 Refs: nodejs/node#17384 PR-URL: nodejs/node#43063 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node/doc/README.md
Line 21 in 5e9274a
Refs: #11321
Refs: #17384