FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

crypto: clean up parameter validation in HKDF by tniessen · Pull Request #42924 · nodejs/node · GitHub

/ node Public

crypto: clean up parameter validation in HKDF - #42924

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
tniessen:crypto-hkdf-validation
May 2, 2022
ConversationCommits (1)ChecksFiles changed
Merged

crypto: clean up parameter validation in HKDF#42924
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
tniessen:crypto-hkdf-validation

Conversation

tniessen commented Apr 30, 2022

Copy link
Copy Markdown
Member
  • validateByteSource internally always calls toBuf, so reuse that value instead of calling toBuf both in validateParameters and in validateByteSource.
  • Validate digest before key. This improves the error message when no arguments are specified: it now refers to the type of the first argument, not to the type of the second argument.

tniessen requested a review from jasnell April 30, 2022 02:29

nodejs-github-bot commented Apr 30, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Apr 30, 2022
tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 30, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 30, 2022

This comment was marked as outdated.

Sign in to view
panva added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 30, 2022

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

tniessen commented Apr 30, 2022

Copy link
Copy Markdown
Member Author

Only CI failure due to #42741.

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Apr 30, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43797/

This was referenced May 1, 2022
Open
Open
aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 2, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 2, 2022
nodejs-github-bot merged commit 75dbb86 into nodejs:master May 2, 2022

nodejs-github-bot commented May 2, 2022

Copy link
Copy Markdown
Collaborator

Landed in 75dbb86

This was referenced May 3, 2022
Open
Open
Open
RafaelGSS pushed a commit that referenced this pull request May 10, 2022
crypto: clean up parameter validation in HKDF
183bcc0 
PR-URL: #42924
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
RafaelGSS mentioned this pull request May 10, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
crypto: clean up parameter validation in HKDF
d2e6701 
PR-URL: #42924
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
crypto: clean up parameter validation in HKDF
59bac0a 
PR-URL: #42924
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
crypto: clean up parameter validation in HKDF
0038348 
PR-URL: #42924
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
crypto: clean up parameter validation in HKDF
baaf778 
PR-URL: #42924
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
crypto: clean up parameter validation in HKDF
f785a83 
PR-URL: nodejs/node#42924
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

panva panva approved these changes
lpinca lpinca approved these changes
himself65 himself65 approved these changes
aduh95 aduh95 approved these changes
jasnell Awaiting requested review from jasnell
+1 more reviewer
VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL