FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: remove unnecessary comment in node_process_events.cc by cola119 · Pull Request #42952 · nodejs/node · GitHub

/ node Public

src: remove unnecessary comment in node_process_events.cc - #42952

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
cola119:chore-remove-unnecessary-comment
May 6, 2022
ConversationCommits (1)ChecksFiles changed
Merged

src: remove unnecessary comment in node_process_events.cc#42952
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
cola119:chore-remove-unnecessary-comment

Conversation

cola119 commented May 3, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

I found meaningless comment in node_process_events.cc. I think this is unintentionally duplicated by #25397 (cc @joyeecheung)
The correct location of this comment is here:

node/src/inspector_agent.cc

Lines 341 to 351 in 2be5966

void NotifyClusterWorkersDebugEnabled(Environment* env) {
Isolate* isolate = env->isolate();
HandleScope handle_scope(isolate);
Local<Context> context = env->context();
// Send message to enable debug in cluster workers
Local<Object> message = Object::New(isolate);
message->Set(context, FIXED_ONE_BYTE_STRING(isolate, "cmd"),
FIXED_ONE_BYTE_STRING(isolate, "NODE_DEBUG_ENABLED")).Check();
ProcessEmit(env, "internalMessage", message);
}

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 3, 2022
joyeecheung approved these changes May 5, 2022
View reviewed changes

joyeecheung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I have no idea why this comment was added but yeah the analysis sounds about right 👍

tniessen added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels May 6, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2022

nodejs-github-bot commented May 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43906/

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2022
nodejs-github-bot merged commit 3bc23f5 into nodejs:master May 6, 2022

nodejs-github-bot commented May 6, 2022

Copy link
Copy Markdown
Collaborator

Landed in 3bc23f5

cola119 deleted the chore-remove-unnecessary-comment branch May 7, 2022 03:42
RafaelGSS pushed a commit that referenced this pull request May 10, 2022
src: remove unnecessary comment
5dc7929 
PR-URL: #42952
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
RafaelGSS mentioned this pull request May 10, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
src: remove unnecessary comment
eecf820 
PR-URL: #42952
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
src: remove unnecessary comment
31d77ad 
PR-URL: #42952
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Jul 12, 2022
src: remove unnecessary comment
3b09330 
PR-URL: #42952
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Jul 31, 2022
src: remove unnecessary comment
4cfcb6f 
PR-URL: #42952
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
src: remove unnecessary comment
ceef45c 
PR-URL: nodejs/node#42952
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tniessen tniessen approved these changes
joyeecheung joyeecheung approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL