FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: reorganize process object creation, property implementation and events in C++ land by joyeecheung · Pull Request #25397 · nodejs/node · GitHub

/ node Public

src: reorganize process object creation, property implementation and events in C++ land - #25397

Closed
joyeecheung wants to merge 7 commits into
nodejs:masterfrom
joyeecheung:move-process
ConversationCommits (7)ChecksFiles changed
Closed

src: reorganize process object creation, property implementation and events in C++ land#25397
joyeecheung wants to merge 7 commits into
nodejs:masterfrom
joyeecheung:move-process

Conversation

joyeecheung commented Jan 8, 2019

Copy link
Copy Markdown
Member

src: move process object creation into node_process_object.cc

Changes SetupProcessObject to CreateProessObject which creates
the process object from scratch and return it to Environment::Start
to be stored in the Environment object.

src: declare process-related C++ methods in node_process.h

Instead of in node_internals.h. Also move process property
accessors that are not reused into node_process_object.cc
and make them static.

process: move C++ process events into node_process_events.cc

Move the C++ process.emit and process.emitWarning methods
from node.cc into into node_process_events.cc, and
reuse the implementation in other places that need to do
process.emit in C++.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot commented Jan 8, 2019

Copy link
Copy Markdown
Collaborator

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2182/pipeline

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jan 8, 2019

joyeecheung commented Jan 8, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/19999/
CI: https://ci.nodejs.org/job/node-test-pull-request/20001/

jasnell approved these changes Jan 8, 2019
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Very happy to see the ongoing cleanup and reorganization here.

addaleax approved these changes Jan 8, 2019
View reviewed changes
Comment thread src/node.cc Outdated
Comment thread src/inspector_agent.cc Outdated

addaleax Jan 8, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This sounds like something we might want to migrate off process.emit(), right?

joyeecheung Jan 9, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@addaleax yeah, this looks like the only place where internalMessage is emitted, maybe the C++ side can call a method passed from JS side somehow instead ..

joyeecheung commented Jan 9, 2019

Copy link
Copy Markdown
Member Author

Fixed the includes: https://ci.nodejs.org/job/node-test-pull-request/20022/

joyeecheung added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 9, 2019
src: move process object creation into node_process_object.cc
60d3a5e 
Changes `SetupProcessObject` to `CreateProessObject` which creates
the process object from scratch and return it to `Environment::Start`
to be stored in the Environment object.
src: declare process-related C++ methods in node_process.h
a28145b 
Instead of in node_internals.h. Also move process property
accessors that are not reused into node_process_object.cc
and make them static.
process: move C++ process events into node_process_events.cc
5e1b8a2 
Move the C++ `process.emit` and `process.emitWarning` methods
from `node.cc` into into `node_process_events.cc`, and
reuse the implementation in other places that need to do
`process.emit` in C++.
fixup! src: move process object creation into node_process_object.cc
ff4e9de
fixup! src: declare process-related C++ methods in node_process.h
cc8d7e3
fixup! src: move process object creation into node_process_object.cc
cdd42e7
fixup! process: move C++ process events into node_process_events.cc
b05ae4e

joyeecheung commented Jan 9, 2019

Copy link
Copy Markdown
Member Author

Need a rebase to resolve the linter failure. CI: https://ci.nodejs.org/job/node-test-pull-request/20026/

joyeecheung commented Jan 11, 2019

Copy link
Copy Markdown
Member Author

Landed in 4c9ea8f...84f0581

joyeecheung added a commit that referenced this pull request Jan 11, 2019
src: move process object creation into node_process_object.cc
5a15f4b 
Changes `SetupProcessObject` to `CreateProessObject` which creates
the process object from scratch and return it to `Environment::Start`
to be stored in the Environment object.

PR-URL: #25397
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
joyeecheung added a commit that referenced this pull request Jan 11, 2019
src: declare process-related C++ methods in node_process.h
7824280 
Instead of in node_internals.h. Also move process property
accessors that are not reused into node_process_object.cc
and make them static.

PR-URL: #25397
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
joyeecheung added a commit that referenced this pull request Jan 11, 2019
process: move C++ process events into node_process_events.cc
84f0581 
Move the C++ `process.emit` and `process.emitWarning` methods
from `node.cc` into into `node_process_events.cc`, and
reuse the implementation in other places that need to do
`process.emit` in C++.

PR-URL: #25397
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Jan 15, 2019
src: move process object creation into node_process_object.cc
7cbbd68 
Changes `SetupProcessObject` to `CreateProessObject` which creates
the process object from scratch and return it to `Environment::Start`
to be stored in the Environment object.

PR-URL: #25397
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Jan 15, 2019
src: declare process-related C++ methods in node_process.h
d4ef922 
Instead of in node_internals.h. Also move process property
accessors that are not reused into node_process_object.cc
and make them static.

PR-URL: #25397
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Jan 15, 2019
process: move C++ process events into node_process_events.cc
d7a07d8 
Move the C++ `process.emit` and `process.emitWarning` methods
from `node.cc` into into `node_process_events.cc`, and
reuse the implementation in other places that need to do
`process.emit` in C++.

PR-URL: #25397
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
src: move process object creation into node_process_object.cc
233026a 
Changes `SetupProcessObject` to `CreateProessObject` which creates
the process object from scratch and return it to `Environment::Start`
to be stored in the Environment object.

PR-URL: nodejs#25397
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
src: declare process-related C++ methods in node_process.h
b9f9706 
Instead of in node_internals.h. Also move process property
accessors that are not reused into node_process_object.cc
and make them static.

PR-URL: nodejs#25397
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
process: move C++ process events into node_process_events.cc
0ec70d2 
Move the C++ `process.emit` and `process.emitWarning` methods
from `node.cc` into into `node_process_events.cc`, and
reuse the implementation in other places that need to do
`process.emit` in C++.

PR-URL: nodejs#25397
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 17, 2019
src: move process object creation into node_process_object.cc
49ac968 
Changes `SetupProcessObject` to `CreateProessObject` which creates
the process object from scratch and return it to `Environment::Start`
to be stored in the Environment object.

PR-URL: nodejs#25397
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 17, 2019
src: declare process-related C++ methods in node_process.h
2ed3fa1 
Instead of in node_internals.h. Also move process property
accessors that are not reused into node_process_object.cc
and make them static.

PR-URL: nodejs#25397
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 17, 2019
process: move C++ process events into node_process_events.cc
28baf26 
Move the C++ `process.emit` and `process.emitWarning` methods
from `node.cc` into into `node_process_events.cc`, and
reuse the implementation in other places that need to do
`process.emit` in C++.

PR-URL: nodejs#25397
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins mentioned this pull request Jan 24, 2019
Merged
cola119 mentioned this pull request May 3, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
jasnell jasnell approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL