FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: use consistent method symbol by ShogunPanda · Pull Request #42974 · nodejs/node · GitHub

/ node Public

doc: use consistent method symbol - #42974

Merged
nodejs-github-bot merged 4 commits into
nodejs:masterfrom
ShogunPanda:https-docs-consistency
May 10, 2022
Merged

doc: use consistent method symbol#42974
nodejs-github-bot merged 4 commits into
nodejs:masterfrom
ShogunPanda:https-docs-consistency

Conversation

Copy link
Copy Markdown
Contributor

This PR fixed little inconsistency in symbol used to denote class method in HTTP, HTTPS and HTTP2 documentation.

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net

nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 5, 2022
Comment thread doc/api/http2.md Outdated
ShogunPanda force-pushed the https-docs-consistency branch from 2305b31 to 19c0492 Compare May 10, 2022 10:59
Comment thread doc/api/http2.md Outdated
Comment thread doc/api/https.md Outdated

Copy link
Copy Markdown
Contributor Author

@aduh95 I've updated all the reference to use node:. It is good to go now?

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 10, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 10, 2022
nodejs-github-bot merged commit f095b19 into nodejs:master May 10, 2022

Copy link
Copy Markdown
Collaborator

Landed in f095b19

BethGriggs pushed a commit that referenced this pull request May 16, 2022
PR-URL: #42974
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
RafaelGSS mentioned this pull request May 16, 2022
juanarbol pushed a commit that referenced this pull request May 31, 2022
PR-URL: #42974
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
ShogunPanda deleted the https-docs-consistency branch June 27, 2022 10:39
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
PR-URL: #42974
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #42974
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #42974
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#42974
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL