test: validate webstream encoder/decoder inspector - #42747
Merged
nodejs-github-bot merged 1 commit intoMay 5, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
websteam -> webstream in the commit message |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
inpector -> inspector in commit message title, inspcetor -> inspector in commit message. |
Sorry, something went wrong.
jasnell
approved these changes
Apr 15, 2022
jasnell
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with the nits addressed
Sorry, something went wrong.
RaisinTen
approved these changes
Apr 16, 2022
lpinca
approved these changes
Apr 16, 2022
tniessen
approved these changes
Apr 17, 2022
Mesteery
approved these changes
Apr 17, 2022
kuriyosh
force-pushed
the
test-decoder-encoder-inspector
branch
from
b635acf to
b50ae1c
Compare
April 22, 2022 08:42
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
11 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
18 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Apr 29, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/42747 ✔ Done loading data for nodejs/node/pull/42747 ----------------------------------- PR info ------------------------------------ Title test: validate webstream encoder/decoder inspector (#42747) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch kuriyosh:test-decoder-encoder-inspector -> nodejs:master Labels test, author ready, needs-ci Commits 1 - test: validate webstream encoder/decoder inspector Committers 1 - Yoshiki Kurihara PR-URL: https://github.com/nodejs/node/pull/42747 Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/webstreams/encoding.js.html#L98 Reviewed-By: James M Snell Reviewed-By: Darshan Sen Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: Mestery ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42747 Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/webstreams/encoding.js.html#L98 Reviewed-By: James M Snell Reviewed-By: Darshan Sen Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: Mestery -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - test: validate webstream encoder/decoder inspector ℹ This PR was created on Fri, 15 Apr 2022 08:54:07 GMT ✔ Approvals: 5 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/42747#pullrequestreview-943586815 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/42747#pullrequestreview-943860485 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/42747#pullrequestreview-943878628 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/42747#pullrequestreview-943931404 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/42747#pullrequestreview-943982998 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-05-02T17:36:01Z: https://ci.nodejs.org/job/node-test-pull-request/43828/ - Querying data for job/node-test-pull-request/43828/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2259637964 |
Sorry, something went wrong.
33 tasks
aduh95
approved these changes
May 5, 2022
RafaelGSS
pushed a commit
that referenced
this pull request
May 10, 2022
PR-URL: #42747 Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/webstreams/encoding.js.html#L98 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
PR-URL: #42747 Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/webstreams/encoding.js.html#L98 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
PR-URL: #42747 Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/webstreams/encoding.js.html#L98 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #42747 Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/webstreams/encoding.js.html#L98 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #42747 Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/webstreams/encoding.js.html#L98 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#42747 Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/webstreams/encoding.js.html#L98 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This validates that inspcetor outputs of TextEncoderStream & TextDecoderStream in internal/webstreams.
ref: