| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Signed-off-by: Michael Dawson <mdawson@devrus.com>
|
Report from coverity: 26 private:
27 WasmStreamingObject(Environment* env, v8::Local<v8::Object> object)
28 : BaseObject(env, object) {
29 MakeWeak();
CID 254660 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member wasm_size_ is not initialized in this constructor nor in any functions that it calls.
30 }
31
32 ~WasmStreamingObject() override {}
33
34 private:
35 static void New(const v8::FunctionCallbackInfo<v8::Value>& args);
36 static void SetURL(const v8::FunctionCallbackInfo<v8::Value>& args);
37 static void Push(const v8::FunctionCallbackInfo<v8::Value>& args);
38 static void Finish(const v8::FunctionCallbackInfo<v8::Value>& args);
39 static void Abort(const v8::FunctionCallbackInfo<v8::Value>& args);
40
41 std::shared_ptr<v8::WasmStreaming> streaming_;
1. member_decl: Class member declaration for wasm_size_.
42 size_t wasm_size_;
43}; |
Sorry, something went wrong.
|
FWIW, this is where the initialization currently happens: Lines 58 to 70 in 68fb0bf Other functions rely on the assumption that the initialization ran (e.g., will abort the process if streaming_ has not been initialized to a non-nullptr value). Eventually, we might want to revisit how we initialize C++ backed JS objects in general. |
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #42897 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #42897 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
| Back | FazBrowse Home | New Git URL |
Signed-off-by: Michael Dawson mdawson@devrus.com