crypto: adjust minimum length in generateKey('hmac', ...) and generateKeySync('hmac', ...) - #42944
Conversation
Sorry, something went wrong.
Also affects generateKeySync('hmac', ...)
|
Review requested:
|
Sorry, something went wrong.
tniessen
left a comment
There was a problem hiding this comment.
LGTM. Not sure about the semver-ity though.
Sorry, something went wrong.
|
semver-patch I guess? On that interval, this PR replaces abortion with RangeError. |
Sorry, something went wrong.
There was a problem hiding this comment.
I believe this surfaced together with Web Crypto API. I also believe the intention was to follow the way Web Crypto API works in Node.js, that is "multiples of 8", in which case, length should've been in bytes, not bits...
Since any other bit length that isn't a multiple of 8 is rounded down, this patched behaviour is IMHO correct and falls within a fix semver-ity ;)
cc @jasnell
Sorry, something went wrong.
|
Ah, I didn't know this aborted before. semver-patch is fine then! |
Sorry, something went wrong.
This comment was marked as outdated.
Sorry, something went wrong.
Also affects generateKeySync('hmac', ...)
PR-URL: #42944
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Also affects generateKeySync('hmac', ...)
PR-URL: #42944
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Also affects generateKeySync('hmac', ...)
PR-URL: #42944
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Also affects generateKeySync('hmac', ...)
PR-URL: #42944
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Also affects generateKeySync('hmac', ...)
PR-URL: #42944
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Also affects generateKeySync('hmac', ...)
PR-URL: nodejs/node#42944
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Values in the interval [1, 8) are invalid.