test: reduce flakiness of test-fs-read-position-validation.mjs - #42999
Merged
nodejs-github-bot merged 9 commits intoMay 15, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
aduh95
reviewed
May 7, 2022
Comment thread
test/parallel/test-fs-read-position-validation.mjs
Outdated
aduh95
reviewed
May 7, 2022
Comment thread
test/parallel/test-fs-read-position-validation.mjs
Outdated
aduh95
reviewed
May 7, 2022
Comment thread
test/parallel/test-fs-read-position-validation.mjs
Outdated
Comment thread
test/parallel/test-fs-read-position-validation.mjs
Outdated
Comment thread
test/parallel/test-fs-read-position-validation.mjs
Outdated
aduh95
reviewed
May 7, 2022
Comment thread
test/parallel/test-fs-read-position-validation.mjs
Outdated
Comment thread
test/parallel/test-fs-read-position-validation.mjs
Outdated
aduh95
reviewed
May 9, 2022
Comment thread
test/parallel/test-fs-read-position-validation.mjs
Outdated
aduh95
approved these changes
May 9, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced May 14, 2022
Merged
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
LiviaMedeiros
force-pushed
the
fs-reads-position-test-segregate
branch
from
523f1b9 to
11a5b35
Compare
May 15, 2022 08:34
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
approved these changes
May 15, 2022
BethGriggs
pushed a commit
that referenced
this pull request
May 16, 2022
PR-URL: #42999 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
PR-URL: #42999 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Copy link
Copy Markdown
Contributor
|
@LiviaMedeiros this breaks tests when landing in v16.x. Do you mind creating a backport PR to v16.x-staging? Thanks |
Sorry, something went wrong.
LiviaMedeiros
added a commit
to LiviaMedeiros/node
that referenced
this pull request
Jun 27, 2022
PR-URL: nodejs#42999 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Backport-PR-URL: nodejs#43588
targos
pushed a commit
that referenced
this pull request
Jul 18, 2022
PR-URL: #42999 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #42999 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#42999 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Some platforms may return `EOVERFLOW` errors instead of `EFBIG`. PR-URL: nodejs/node#43510 Refs: nodejs/node#42999 Refs: nodejs/node#43509 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The said test failed randomly several times with EBADF error code: [1], [2], [3]
This PR should make the test more reliable by promisifying Callback API parts and calling them in sequence.
Additionally, it separates Callback API and Synchronous API parts into two tests, in anticipation of validation in Promises API.