doc: add detail for how to update llhttp - #43028
Closed
mhdawson wants to merge 6 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Add detail on how to update llhttp in deps to the guide for maintaining http. Signed-off-by: Michael Dawson <mdawson@devrus.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
VoltrexKeyva
reviewed
May 9, 2022
Comment thread
doc/contributing/maintaining-http.md
Outdated
Comment thread
doc/contributing/maintaining-http.md
Outdated
Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
RaisinTen
reviewed
May 10, 2022
Comment thread
doc/contributing/maintaining-http.md
Outdated
mcollina
approved these changes
May 10, 2022
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
cc @ShogunPanda
Sorry, something went wrong.
ShogunPanda
approved these changes
May 10, 2022
ShogunPanda
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
richardlau
approved these changes
May 10, 2022
richardlau
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM for a regular update but this isn't what we've been doing for security updates -- in that case before we do the Node.js security release and disclose the vulnerability the upstream llhttp doesn't have the security patches (otherwise they would be disclosed prematurely).
Sorry, something went wrong.
Co-authored-by: Darshan Sen <raisinten@gmail.com>
RaisinTen
approved these changes
May 10, 2022
VoltrexKeyva
approved these changes
May 10, 2022
lpinca
approved these changes
May 10, 2022
Copy link
Copy Markdown
Member
|
We'll need some process for security releases for llhttp. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@mcollina adding instructions for security releases makes sense but I think can be a follow on PR once we figure that out. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Agreed |
Sorry, something went wrong.
mhdawson
added a commit
that referenced
this pull request
May 12, 2022
Add detail on how to update llhttp in deps to the guide for maintaining http. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #43028 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
May 16, 2022
Add detail on how to update llhttp in deps to the guide for maintaining http. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #43028 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
Add detail on how to update llhttp in deps to the guide for maintaining http. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #43028 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
Add detail on how to update llhttp in deps to the guide for maintaining http. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #43028 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
Add detail on how to update llhttp in deps to the guide for maintaining http. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #43028 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
Add detail on how to update llhttp in deps to the guide for maintaining http. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #43028 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Add detail on how to update llhttp in deps to the guide for maintaining http. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs/node#43028 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add detail on how to update llhttp in deps to the
guide for maintaining http.
Signed-off-by: Michael Dawson mdawson@devrus.com