test: rename handlewrap.hasref tests - #42754
Merged
nodejs-github-bot merged 1 commit intoMay 5, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
RaisinTen
approved these changes
Apr 16, 2022
This comment was marked as outdated.
tniessen
approved these changes
Apr 16, 2022
marsonya
approved these changes
Apr 16, 2022
lpinca
approved these changes
Apr 16, 2022
This comment was marked as outdated.
15 tasks
Mesteery
approved these changes
Apr 17, 2022
This was referenced Apr 18, 2022
`HandleWrap.isRefed()` was renamed to `hasRef()`. However, the filename of related TCs has not been reflected. Refs: nodejs@f31a5ec34a
daeyeon
force-pushed
the
master.node-220416.Sat.dc24
branch
from
1c799bc to
7a53e6b
Compare
April 19, 2022 17:44
This comment was marked as outdated.
16 tasks
Copy link
Copy Markdown
Member
Author
|
Can someone check if the Jenkins CI tests are flaky or timeout? Am I missing something? If not, please re-trigger them? Thanks in advance! |
Sorry, something went wrong.
This comment was marked as outdated.
jasnell
approved these changes
Apr 20, 2022
This was referenced Apr 21, 2022
This comment was marked as outdated.
This was referenced Apr 27, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced May 3, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
RafaelGSS
pushed a commit
that referenced
this pull request
May 10, 2022
`HandleWrap.isRefed()` was renamed to `hasRef()`. However, the filename of related TCs has not been reflected. Refs: f31a5ec34a PR-URL: #42754 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
`HandleWrap.isRefed()` was renamed to `hasRef()`. However, the filename of related TCs has not been reflected. Refs: f31a5ec34a PR-URL: #42754 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
`HandleWrap.isRefed()` was renamed to `hasRef()`. However, the filename of related TCs has not been reflected. Refs: f31a5ec34a PR-URL: #42754 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
`HandleWrap.isRefed()` was renamed to `hasRef()`. However, the filename of related TCs has not been reflected. Refs: f31a5ec34a PR-URL: #42754 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
`HandleWrap.isRefed()` was renamed to `hasRef()`. However, the filename of related TCs has not been reflected. Refs: f31a5ec34a PR-URL: #42754 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
`HandleWrap.isRefed()` was renamed to `hasRef()`. However, the filename of related TCs has not been reflected. Refs: nodejs/node@f31a5ec34a PR-URL: nodejs/node#42754 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HandleWrap.isRefed() was renamed to hasRef(). However, the filename
of related TCs has not been reflected.
Refs: f31a5ec34a