meta: update .mailmap for recent README name change - #43027
Merged
Trott merged 1 commit intoMay 10, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
Sorry, something went wrong.
himself65
approved these changes
May 9, 2022
Trott
commented
May 9, 2022
Comment thread
AUTHORS
Outdated
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
This line is a side-effect of running tools/update-authors.js after updating .mailmap. I think it's fine to leave it, rather than removing it only so that the scheduled job re-adds it in a few days.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Without this change, it's possible that tools/find-inactive-collaborators.js will incorrectly flag the user as inactive. |
Sorry, something went wrong.
tniessen
approved these changes
May 9, 2022
Copy link
Copy Markdown
Member
Author
|
Removed commit-queue label because this needs one more fast-track approval. Feel free to add it back if/when this gets that second approval. |
Sorry, something went wrong.
lpinca
approved these changes
May 10, 2022
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/43027 ✔ Done loading data for nodejs/node/pull/43027 ----------------------------------- PR info ------------------------------------ Title meta: update .mailmap for recent README name change (#43027) Author Rich Trott (@Trott) Branch Trott:update -> nodejs:master Labels fast-track, author ready Commits 1 - meta: update .mailmap for recent README name change Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/43027 Reviewed-By: Zeyu "Alex" Yang Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43027 Reviewed-By: Zeyu "Alex" Yang Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 09 May 2022 21:00:27 GMT ✔ Approvals: 3 ✔ - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/43027#pullrequestreview-966828530 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43027#pullrequestreview-966884084 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43027#pullrequestreview-967180646 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least two collaborators' approvals (👍). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2298687477 |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/43027 ✔ Done loading data for nodejs/node/pull/43027 ----------------------------------- PR info ------------------------------------ Title meta: update .mailmap for recent README name change (#43027) Author Rich Trott (@Trott) Branch Trott:update -> nodejs:master Labels fast-track, author ready Commits 1 - meta: update .mailmap for recent README name change Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/43027 Reviewed-By: Zeyu "Alex" Yang Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43027 Reviewed-By: Zeyu "Alex" Yang Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 09 May 2022 21:00:27 GMT ✔ Approvals: 3 ✔ - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/43027#pullrequestreview-966828530 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43027#pullrequestreview-966884084 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43027#pullrequestreview-967180646 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least two collaborators' approvals (👍). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2301687056 |
Sorry, something went wrong.
PR-URL: nodejs#43027 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
May 16, 2022
PR-URL: #43027 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
PR-URL: #43027 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
PR-URL: #43027 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43027 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43027 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43027 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.