FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: use serial comma in fs docs by tniessen · Pull Request #43104 · nodejs/node · GitHub

/ node Public

doc: use serial comma in fs docs - #43104

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
tniessen:doc-serial-comma-fs
May 15, 2022
ConversationCommits (1)ChecksFiles changed
Merged

doc: use serial comma in fs docs#43104
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
tniessen:doc-serial-comma-fs

Conversation

tniessen commented May 14, 2022

Copy link
Copy Markdown
Member

node/doc/README.md

Line 21 in 5e9274a

* [Use serial commas][].

Refs: #11321
Refs: #17384

tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label May 14, 2022

github-actions Bot commented May 14, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels May 14, 2022
LiviaMedeiros approved these changes May 14, 2022
View reviewed changes

LiviaMedeiros left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nits, feel free to ignore or leave for later:
https://github.com/nodejs/node/blob/4d5bbc7ea1c4fed240397a5b96a1572ba204f2b4/doc/api/fs.md#L1562
https://github.com/nodejs/node/blob/4d5bbc7ea1c4fed240397a5b96a1572ba204f2b4/doc/api/fs.md#L1687
https://github.com/nodejs/node/blob/4d5bbc7ea1c4fed240397a5b96a1572ba204f2b4/doc/api/fs.md#L2412
https://github.com/nodejs/node/blob/4d5bbc7ea1c4fed240397a5b96a1572ba204f2b4/doc/api/fs.md#L3876
https://github.com/nodejs/node/blob/4d5bbc7ea1c4fed240397a5b96a1572ba204f2b4/doc/api/fs.md#L7524

Out of curiosity, maybe comma should be used in those as well, since any TypedArray is equivalent of Int8Array, ..., or Float64Array:
https://github.com/nodejs/node/blob/4d5bbc7ea1c4fed240397a5b96a1572ba204f2b4/doc/api/fs.md#L4395-L4396

tniessen force-pushed the doc-serial-comma-fs branch from 1238886 to d9a91c4 Compare May 15, 2022 14:18

tniessen commented May 15, 2022

Copy link
Copy Markdown
Member Author

Thanks @LiviaMedeiros, I missed those! Force-pushed, the actual diff since the first commit is 1238886ecdf0a1f0c20cb2184bb4e9780bd1dc2b. PTAL.

LiviaMedeiros reviewed May 15, 2022
View reviewed changes
Comment thread doc/api/fs.md Outdated
tniessen force-pushed the doc-serial-comma-fs branch from cf0fb14 to 4aac703 Compare May 15, 2022 16:45

tniessen commented May 15, 2022

Copy link
Copy Markdown
Member Author

Thanks for catching that @LiviaMedeiros! Force-pushed again, the actual diff is cf0fb1426cfefe9ae315f65c99390749174b0b4f.

LiviaMedeiros added the commit-queue Add this label to land a pull request using GitHub Actions. label May 15, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 15, 2022
nodejs-github-bot merged commit d1d30d7 into nodejs:master May 15, 2022

nodejs-github-bot commented May 15, 2022

Copy link
Copy Markdown
Collaborator

Landed in d1d30d7

BethGriggs pushed a commit that referenced this pull request May 16, 2022
doc: use serial comma in fs docs
f53ed9d 
Refs: #11321
Refs: #17384

PR-URL: #43104
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
RafaelGSS mentioned this pull request May 16, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
doc: use serial comma in fs docs
ac9cbba 
Refs: #11321
Refs: #17384

PR-URL: #43104
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
doc: use serial comma in fs docs
f5f2c86 
Refs: #11321
Refs: #17384

PR-URL: #43104
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
doc: use serial comma in fs docs
9705445 
Refs: #11321
Refs: #17384

PR-URL: #43104
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
doc: use serial comma in fs docs
a61b7fa 
Refs: #11321
Refs: #17384

PR-URL: #43104
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
doc: use serial comma in fs docs
a0e8fd1 
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#43104
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
RaisinTen RaisinTen approved these changes
LiviaMedeiros LiviaMedeiros approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL