FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src,crypto: remove uses of `AllocatedBuffer` from `crypto_rsa.cc` by RaisinTen · Pull Request #42852 · nodejs/node · GitHub

/ node Public

src,crypto: remove uses of AllocatedBuffer from crypto_rsa.cc - #42852

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
RaisinTen:src,crypto/remove-uses-of-AllocatedBuffer-from-crypto_rsa.cc
May 4, 2022
Merged

src,crypto: remove uses of AllocatedBuffer from crypto_rsa.cc#42852
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
RaisinTen:src,crypto/remove-uses-of-AllocatedBuffer-from-crypto_rsa.cc

Conversation

Copy link
Copy Markdown
Member

Refs: #39941
Signed-off-by: Darshan Sen raisinten@gmail.com

Refs: nodejs#39941
Signed-off-by: Darshan Sen <raisinten@gmail.com>

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Apr 24, 2022

This comment was marked as outdated.

This comment was marked as outdated.

Copy link
Copy Markdown
Member Author

@addaleax PTAL.

RaisinTen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 4, 2022

Copy link
Copy Markdown
Collaborator

tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 4, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 4, 2022
nodejs-github-bot merged commit 7ff2170 into nodejs:master May 4, 2022

Copy link
Copy Markdown
Collaborator

Landed in 7ff2170

RaisinTen deleted the src,crypto/remove-uses-of-AllocatedBuffer-from-crypto_rsa.cc branch May 5, 2022 04:41
RafaelGSS pushed a commit that referenced this pull request May 10, 2022
Refs: #39941
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42852
Reviewed-By: Anna Henningsen <anna@addaleax.net>
RafaelGSS mentioned this pull request May 10, 2022
juanarbol pushed a commit that referenced this pull request May 31, 2022
Refs: #39941
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42852
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
Refs: #39941
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42852
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Jul 12, 2022
Refs: #39941
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42852
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Jul 31, 2022
Refs: #39941
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42852
Reviewed-By: Anna Henningsen <anna@addaleax.net>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#39941
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: nodejs/node#42852
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL