FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add the preferred name for @himself65 by himself65 · Pull Request #43024 · nodejs/node · GitHub

/ node Public

doc: add the preferred name for @himself65 - #43024

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
himself65:20220509-add-preferred-name
May 9, 2022
Merged

doc: add the preferred name for @himself65#43024
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
himself65:20220509-add-preferred-name

Conversation

Copy link
Copy Markdown
Member

No description provided.

himself65 added the fast-track PRs that do not need to wait for 48 hours to land. label May 9, 2022

github-actions Bot commented May 9, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @himself65. Please 👍 to approve.

nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 9, 2022
tniessen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 9, 2022
tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2022

Trott commented May 9, 2022

Copy link
Copy Markdown
Member

Should the the .mailmap and AUTHORS files be updated too? (Non-blocking question. They can always be updated later.)

tniessen removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2022
nodejs-github-bot merged commit 721fd01 into nodejs:master May 9, 2022

Copy link
Copy Markdown
Collaborator

Landed in 721fd01

Copy link
Copy Markdown
Member Author

Should the the .mailmap and AUTHORS files be updated too? (Non-blocking question. They can always be updated later.)

oh, they might should. I didn't aware that

BethGriggs pushed a commit that referenced this pull request May 16, 2022
PR-URL: #43024
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
RafaelGSS mentioned this pull request May 16, 2022
juanarbol pushed a commit that referenced this pull request May 31, 2022
PR-URL: #43024
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
PR-URL: #43024
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43024
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43024
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43024
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL