Commit a1c9403
tools: fix --v8-non-optimized-debug for v18.x
Disable SLOW_DCHECKs on v18.x because they don't compile without
the patches in https://bugs.chromium.org/p/v8/issues/detail?id=12887
if used in constexpr, which can happen in other floated patches.
PR-URL: #50612
Reviewed-By: Michaël Zasso <targos@protonmail.com>1 parent 7af5427 commit a1c9403
1 file changed
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -90,6 +90,11 @@ | |||
| 90 | 90 | # Set to 1 to enable DCHECKs in release builds. | |
| 91 | 91 | 'dcheck_always_on%': 0, | |
| 92 | 92 | ||
| 93 | + # For v18.x, disable SLOW_DCHECKs because they don't compile without | ||
| 94 | + # the patches in https://bugs.chromium.org/p/v8/issues/detail?id=12887 | ||
| 95 | + # if used in constexpr, which can happen in other floated patches. | ||
| 96 | + 'v8_enable_slow_dchecks%': 0, | ||
| 97 | + | ||
| 93 | 98 | # Sets -DV8_ENABLE_FUTURE. | |
| 94 | 99 | 'v8_enable_future%': 0, | |
| 95 | 100 | ||
0 commit comments