tools: fix --v8-non-optimized-debug for v18.x - #50612
Closed
joyeecheung wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Disable SLOW_DCHECKs on v18.x because they don't compile without the patches in https://bugs.chromium.org/p/v8/issues/detail?id=12887 if used in constexpr, which can happen in other floated patches.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
targos
approved these changes
Nov 12, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
Disable SLOW_DCHECKs on v18.x because they don't compile without the patches in https://bugs.chromium.org/p/v8/issues/detail?id=12887 if used in constexpr, which can happen in other floated patches. PR-URL: #50612 Reviewed-By: Michaël Zasso <targos@protonmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Disable SLOW_DCHECKs on v18.x because they don't compile without the patches in https://bugs.chromium.org/p/v8/issues/detail?id=12887 if used in constexpr, which can happen in other floated patches. PR-URL: nodejs/node#50612 Reviewed-By: Michaël Zasso <targos@protonmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Disable SLOW_DCHECKs on v18.x because they don't compile without the patches in https://bugs.chromium.org/p/v8/issues/detail?id=12887 if used in constexpr, which can happen in other floated patches. PR-URL: nodejs/node#50612 Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable SLOW_DCHECKs on v18.x because they don't compile without the patches in https://bugs.chromium.org/p/v8/issues/detail?id=12887 if used in constexpr, which can happen in other floated patches.