| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
1 parent 2a53401 commit a262e2f
6 files changed
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -495,7 +495,7 @@ By doing this, Node.js achieves a few things: | |||
| 495 | 495 | - It keeps top-level variables (defined with `var`, `const` or `let`) scoped to | |
| 496 | 496 | the module rather than the global object. | |
| 497 | 497 | - It helps to provide some global-looking variables that are actually specific | |
| 498 | - to the module, such as: | ||
| 498 | + to the module, such as: | ||
| 499 | 499 | - The `module` and `exports` objects that the implementor can use to export | |
| 500 | 500 | values from the module. | |
| 501 | 501 | - The convenience variables `__filename` and `__dirname`, containing the | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3982,13 +3982,13 @@ Returns `napi_ok` if the API succeeded. | |||
| 3982 | 3982 | N-API offers a way to "wrap" C++ classes and instances so that the class | |
| 3983 | 3983 | constructor and methods can be called from JavaScript. | |
| 3984 | 3984 | ||
| 3985 | - 1. The [`napi_define_class`][] API defines a JavaScript class with constructor, | ||
| 3985 | + 1. The [`napi_define_class`][] API defines a JavaScript class with constructor, | ||
| 3986 | 3986 | static properties and methods, and instance properties and methods that | |
| 3987 | 3987 | correspond to the C++ class. | |
| 3988 | - 2. When JavaScript code invokes the constructor, the constructor callback | ||
| 3988 | + 2. When JavaScript code invokes the constructor, the constructor callback | ||
| 3989 | 3989 | uses [`napi_wrap`][] to wrap a new C++ instance in a JavaScript object, | |
| 3990 | 3990 | then returns the wrapper object. | |
| 3991 | - 3. When JavaScript code invokes a method or property accessor on the class, | ||
| 3991 | + 3. When JavaScript code invokes a method or property accessor on the class, | ||
| 3992 | 3992 | the corresponding `napi_callback` C++ function is invoked. For an instance | |
| 3993 | 3993 | callback, [`napi_unwrap`][] obtains the C++ instance that is the target of | |
| 3994 | 3994 | the call. | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3438,6 +3438,7 @@ https://github.com/nodejs/node/commit/726865af7bbafe58435986f4a193ff11c84e4bfe | |||
| 3438 | 3438 | - Move node.dns into module "dns" | |
| 3439 | 3439 | - Move node.fs into module "posix" | |
| 3440 | 3440 | - process is no longer the global object. GLOBAL is. | |
| 3441 | + | ||
| 3441 | 3442 | For more information on the API changes see: | |
| 3442 | 3443 | http://thread.gmane.org/gmane.comp.lang.javascript.nodejs/6 | |
| 3443 | 3444 | http://thread.gmane.org/gmane.comp.lang.javascript.nodejs/14 | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -421,7 +421,7 @@ https://github.com/nodejs/node/pull/5655 | |||
| 421 | 421 | * **v8**: backport fb4ccae from v8 upstream (Vladimir Krivosheev) #4231 | |
| 422 | 422 | - breakout events from v8 to offer better support for external debuggers | |
| 423 | 423 | * **zlib**: add support for concatenated members (Kári Tristan Helgason) | |
| 424 | - https://github.com/nodejs/node/pull/5120 | ||
| 424 | + https://github.com/nodejs/node/pull/5120 | ||
| 425 | 425 | * Previously, if multiple members were in the same archive, only the first would be read. The others are no longer thrown away. | |
| 426 | 426 | ||
| 427 | 427 | ### Commits | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -57,17 +57,17 @@ for details on patched vulnerabilities. | |||
| 57 | 57 | * **build**: | |
| 58 | 58 | - Disable V8 snapshots - The hashseed embedded in the snapshot is | |
| 59 | 59 | currently the same for all runs of the binary. This opens node up to | |
| 60 | - collision attacks which could result in a Denial of Service. We have | ||
| 61 | - temporarily disabled snapshots until a more robust solution is found | ||
| 62 | - (Ali Ijaz Sheikh) | ||
| 60 | + collision attacks which could result in a Denial of Service. We have | ||
| 61 | + temporarily disabled snapshots until a more robust solution is found | ||
| 62 | + (Ali Ijaz Sheikh) | ||
| 63 | 63 | * **deps**: | |
| 64 | 64 | - CVE-2017-1000381 - The c-ares function ares_parse_naptr_reply(), | |
| 65 | 65 | which is used for parsing NAPTR responses, could be triggered to | |
| 66 | - read memory outside of the given input buffer if the passed in DNS | ||
| 67 | - response packet was crafted in a particular way. This patch checks that | ||
| 68 | - there is enough data for the required elements of an NAPTR record (2 | ||
| 69 | - int16, 3 bytes for string lengths) before processing a record. (David | ||
| 70 | - Drysdale) | ||
| 66 | + read memory outside of the given input buffer if the passed in DNS | ||
| 67 | + response packet was crafted in a particular way. This patch checks that | ||
| 68 | + there is enough data for the required elements of an NAPTR record (2 | ||
| 69 | + int16, 3 bytes for string lengths) before processing a record. (David | ||
| 70 | + Drysdale) | ||
| 71 | 71 | ||
| 72 | 72 | ### Commits | |
| 73 | 73 | ||
@@ -1552,7 +1552,7 @@ Thank you to @italoacasas for preparing the majority of this release. | |||
| 1552 | 1552 | * **buffer**: | |
| 1553 | 1553 | - Reverted the runtime deprecation of calling `Buffer()` without `new`. (Anna Henningsen) [#9529](https://github.com/nodejs/node/pull/9529) | |
| 1554 | 1554 | - Fixed `buffer.transcode()` for single-byte character | |
| 1555 | - encodings to `UCS2`. (Anna Henningsen) [#9838](https://github.com/nodejs/node/pull/9838) | ||
| 1555 | + encodings to `UCS2`. (Anna Henningsen) [#9838](https://github.com/nodejs/node/pull/9838) | ||
| 1556 | 1556 | * **promise**: `--trace-warnings` now produces useful stacktraces for Promise warnings. (Anna Henningsen) [#9525](https://github.com/nodejs/node/pull/9525) | |
| 1557 | 1557 | * **repl**: Fixed a bug preventing correct parsing of generator functions. (Teddy Katz) [#9852](https://github.com/nodejs/node/pull/9852) | |
| 1558 | 1558 | * **V8**: Fixed a significant `instanceof` performance regression. (Franziska Hinkelmann) [#9730](https://github.com/nodejs/node/pull/9730) | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -159,8 +159,8 @@ A good commit message should describe what changed and why. | |||
| 159 | 159 | 3. Wrap all other lines at 72 columns (except for long URLs). | |
| 160 | 160 | ||
| 161 | 161 | 4. If your patch fixes an open issue, you can add a reference to it at the end | |
| 162 | - of the log. Use the `Fixes:` prefix and the full issue URL. For other references | ||
| 163 | - use `Refs:`. | ||
| 162 | + of the log. Use the `Fixes:` prefix and the full issue URL. For other | ||
| 163 | + references use `Refs:`. | ||
| 164 | 164 | ||
| 165 | 165 | Examples: | |
| 166 | 166 | - `Fixes: https://github.com/nodejs/node/issues/1337` | |
| Back | FazBrowse Home | New Git URL |
0 commit comments