FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: indenting child list items for remark-lint by nschonni · Pull Request #29488 · nodejs/node · GitHub

/ node Public

doc: indenting child list items for remark-lint - #29488

Closed
nschonni wants to merge 1 commit into
nodejs:masterfrom
nschonni:doc--indenting-child-list-items-for-remak-lint
Closed

doc: indenting child list items for remark-lint#29488
nschonni wants to merge 1 commit into
nodejs:masterfrom
nschonni:doc--indenting-child-list-items-for-remak-lint

Conversation

nschonni commented Sep 7, 2019

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 7, 2019
Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 8, 2019

nschonni commented Sep 8, 2019

Copy link
Copy Markdown
Member Author

doh, I just noticed that I misspelled "remark" in the commit message when i got the GitHub notification.
I'll push a quick commit message fix

Trott commented Sep 8, 2019

Copy link
Copy Markdown
Member

Child items not aligned to parent are flagged by list-item-bullet-indent
nschonni force-pushed the doc--indenting-child-list-items-for-remak-lint branch from e0df69a to a2bac24 Compare September 8, 2019 02:44

Trott commented Sep 8, 2019

Copy link
Copy Markdown
Member

Trott commented Sep 8, 2019

Copy link
Copy Markdown
Member

Note for whoever lands this: s/indenting/indent/ for the first line of the commit message.

Trott commented Sep 10, 2019

Copy link
Copy Markdown
Member

Landed in f615285

Trott closed this Sep 10, 2019
Trott pushed a commit that referenced this pull request Sep 10, 2019
Child items not aligned to parent are flagged by list-item-bullet-indent

PR-URL: #29488
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
nschonni deleted the doc--indenting-child-list-items-for-remak-lint branch September 10, 2019 13:30
nschonni changed the title doc: indenting child list items for remak-lint doc: indenting child list items for remark-lint Sep 11, 2019
targos pushed a commit that referenced this pull request Sep 20, 2019
Child items not aligned to parent are flagged by list-item-bullet-indent

PR-URL: #29488
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR mentioned this pull request Sep 24, 2019
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
Child items not aligned to parent are flagged by list-item-bullet-indent

PR-URL: #29488
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL