Commit a6053dc
src: add context for TODO comment in env.cc
Add more context around the TODO change required for achieving the
task. When destructuring the isolate and environment_vars from the
environment object, it is leading to recursive dependency and thus not
able to refactor it in a better way.
PR-URL: #37140
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent 354df9e commit a6053dc
1 file changed
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -372,7 +372,8 @@ Environment::Environment(IsolateData* isolate_data, | |||
| 372 | 372 | ||
| 373 | 373 | set_env_vars(per_process::system_environment); | |
| 374 | 374 | // TODO(joyeecheung): pass Isolate* and env_vars to it instead of the entire | |
| 375 | - // env | ||
| 375 | + // env, when the recursive dependency inclusion in "debug-utils.h" is | ||
| 376 | + // resolved. | ||
| 376 | 377 | enabled_debug_list_.Parse(this); | |
| 377 | 378 | ||
| 378 | 379 | // We create new copies of the per-Environment option sets, so that it is | |
0 commit comments