src: added context around the TODO change - #37140
Merged
Trott merged 1 commit intoFeb 6, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
If needed I can work on refactoring it to reduce the recursion but effort vs impact seems odd. |
Sorry, something went wrong.
joyeecheung
approved these changes
Jan 31, 2021
PoojaDurgad
reviewed
Feb 1, 2021
Comment thread
src/env.cc
Outdated
yashLadha
force-pushed
the
chore_minor_comment_addition
branch
2 times, most recently
from
c05c74f to
78f142a
Compare
February 2, 2021 16:01
PoojaDurgad
approved these changes
Feb 3, 2021
Trott
approved these changes
Feb 6, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Add more context around the TODO change required for achieving the task. When destructuring the isolate and environment_vars from the environment object, it is leading to recursive dependency and thus not able to refactor it in a better way. PR-URL: nodejs#37140 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott
force-pushed
the
chore_minor_comment_addition
branch
from
78f142a to
d6e9446
Compare
February 6, 2021 22:37
danielleadams
pushed a commit
that referenced
this pull request
Feb 16, 2021
Add more context around the TODO change required for achieving the task. When destructuring the isolate and environment_vars from the environment object, it is leading to recursive dependency and thus not able to refactor it in a better way. PR-URL: #37140 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added more context around the TODO change required for achieving the
task. When destructuring the isolate and environment_vars from the
environment object, it is leading to recursive dependency and thus not
able to refactor it in a better way.