Commit a6b9299
src: rename --security-reverts to ...-revert
It was called --security-revert prior to 12.x, but changed in
#22490.
See:
nodejs/nodejs.org#2412 (comment)
PR-URL: #29153
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 7f11c72 commit a6b9299
2 files changed
Lines changed: 7 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -645,7 +645,12 @@ PerProcessOptionsParser::PerProcessOptionsParser( | |||
| 645 | 645 | &PerProcessOptions::debug_arraybuffer_allocations, | |
| 646 | 646 | kAllowedInEnvironment); | |
| 647 | 647 | ||
| 648 | - AddOption("--security-reverts", "", &PerProcessOptions::security_reverts); | ||
| 648 | + | ||
| 649 | + // 12.x renamed this inadvertently, so alias it for consistency within the | ||
| 650 | + // release line, while using the original name for consistency with older | ||
| 651 | + // release lines. | ||
| 652 | + AddOption("--security-revert", "", &PerProcessOptions::security_reverts); | ||
| 653 | + AddAlias("--security-reverts", "--security-revert"); | ||
| 649 | 654 | AddOption("--completion-bash", | |
| 650 | 655 | "print source-able bash completion script", | |
| 651 | 656 | &PerProcessOptions::print_bash_completion); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -5,7 +5,7 @@ const { spawnSync } = require('child_process'); | |||
| 5 | 5 | const os = require('os'); | |
| 6 | 6 | ||
| 7 | 7 | const { signal, status, output } = | |
| 8 | - spawnSync(process.execPath, ['--security-reverts=not-a-cve']); | ||
| 8 | + spawnSync(process.execPath, ['--security-revert=not-a-cve']); | ||
| 9 | 9 | assert.strictEqual(signal, null); | |
| 10 | 10 | assert.strictEqual(status, 12); | |
| 11 | 11 | assert.strictEqual( | |
0 commit comments