src: rename --security-reverts to ...-revert - #29153
Closed
sam-github wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
It was called --security-revert prior to 12.x, but changed in nodejs#22490. See: nodejs/nodejs.org#2412 (comment)
addaleax
approved these changes
Aug 15, 2019
addaleax
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Yeah, that looks like an accidental change… do we want to keep an alias so that this is not semver-major for now, i.e. AddAlias("--security-reverts", "--security-revert");?
Sorry, something went wrong.
cjihrig
approved these changes
Aug 15, 2019
richardlau
approved these changes
Aug 15, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Aug 15, 2019
BethGriggs
approved these changes
Aug 15, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
approved these changes
Aug 16, 2019
trivikr
approved these changes
Aug 16, 2019
jasnell
approved these changes
Aug 16, 2019
Trott
pushed a commit
that referenced
this pull request
Aug 17, 2019
It was called --security-revert prior to 12.x, but changed in #22490. See: nodejs/nodejs.org#2412 (comment) PR-URL: #29153 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 19, 2019
It was called --security-revert prior to 12.x, but changed in #22490. See: nodejs/nodejs.org#2412 (comment) PR-URL: #29153 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Aug 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was called --security-revert prior to 12.x, but changed in
#22490.
See:
nodejs/nodejs.org#2412 (comment)
@addaleax good idea?
Checklist