src: do not pass code to ScriptCompiler::CreateCodeCacheForFunction · nodejs/node@a7c0cb8 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit a7c0cb8

Browse filesBrowse the repository at this point in the historyBrowse files

targos

committed

src: do not pass code to ScriptCompiler::CreateCodeCacheForFunction

This is unnecessary, deprecated, and removed in V8 7.0. PR-URL: #22596 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>

1 parent 82732ef commit a7c0cb8
Copy full SHA for a7c0cb8

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_contextify.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_contextify.cc‎

Copy file name to clipboardExpand all lines: src/node_contextify.cc

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -1102,8 +1102,8 @@ void ContextifyContext::CompileFunction(
1102	1102	}
1103	1103
1104	1104	if (produce_cached_data) {
1105		- const std::unique_ptr<ScriptCompiler::CachedData>
1106		- cached_data(ScriptCompiler::CreateCodeCacheForFunction(fun, code));
	1105	+ const std::unique_ptr<ScriptCompiler::CachedData> cached_data(
	1106	+ ScriptCompiler::CreateCodeCacheForFunction(fun));
1107	1107	bool cached_data_produced = cached_data != nullptr;
1108	1108	if (cached_data_produced) {
1109	1109	MaybeLocal<Object> buf = Buffer::Copy(

0 commit comments

Comments

0 (0)