src: do not pass code to ScriptCompiler::CreateCodeCacheForFunction - #22596
Closed
targos wants to merge 1 commit into
Closed
src: do not pass code to ScriptCompiler::CreateCodeCacheForFunction#22596targos wants to merge 1 commit into
targos wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This is unnecessary, deprecated, and removed in V8 7.0.
Copy link
Copy Markdown
Collaborator
|
@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/729/pipeline |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Please 👍 to fast-track. This unbreaks v8-canary. |
Sorry, something went wrong.
cjihrig
approved these changes
Aug 30, 2018
devsnek
approved these changes
Aug 30, 2018
Copy link
Copy Markdown
Member
Author
|
No fast tracking? |
Sorry, something went wrong.
apapirovski
approved these changes
Aug 30, 2018
BridgeAR
approved these changes
Aug 30, 2018
addaleax
approved these changes
Aug 30, 2018
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Resumed:https://ci.nodejs.org/job/node-test-pull-request/16890/ |
Sorry, something went wrong.
targos
added a commit
that referenced
this pull request
Aug 31, 2018
This is unnecessary, deprecated, and removed in V8 7.0. PR-URL: #22596 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Aug 31, 2018
This is unnecessary, deprecated, and removed in V8 7.0. PR-URL: #22596 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
added a commit
that referenced
this pull request
Sep 3, 2018
This is unnecessary, deprecated, and removed in V8 7.0. PR-URL: #22596 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
added a commit
that referenced
this pull request
Sep 6, 2018
This is unnecessary, deprecated, and removed in V8 7.0. PR-URL: #22596 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is unnecessary, deprecated, and removed in V8 7.0.
Checklist