Commit aa4f485
url: set formatUrl method as no side effect
PR-URL: #46884
Backport-PR-URL: #48345
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>1 parent c79e1b7 commit aa4f485
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -313,7 +313,7 @@ void Initialize(Local<Object> target, | |||
| 313 | 313 | void* priv) { | |
| 314 | 314 | SetMethod(context, target, "parse", Parse); | |
| 315 | 315 | SetMethod(context, target, "updateUrl", UpdateUrl); | |
| 316 | - SetMethod(context, target, "formatUrl", FormatUrl); | ||
| 316 | + SetMethodNoSideEffect(context, target, "formatUrl", FormatUrl); | ||
| 317 | 317 | ||
| 318 | 318 | SetMethodNoSideEffect(context, target, "domainToASCII", DomainToASCII); | |
| 319 | 319 | SetMethodNoSideEffect(context, target, "domainToUnicode", DomainToUnicode); | |
0 commit comments