[v18.x] backport Ada v2.x to Node.js v18 by anonrig · Pull Request #48345 · nodejs/node · GitHub

All of the backports below are somehow related to each other and that's why it resulted into a huge back port

Backports

Review requested:

@nodejs/url

@nodejs/build Appreciate it if you could review & merge this since it is a really big backport.

Wrong team. Releases are managed by the release WG and LTS in particular by @nodejs/lts.
FWIW #48036, #48092 and #48223 have yet to go out in a current release. We usually do not consider things being backported to a LTS release line until it has been in a current release for two weeks.

Wrong team.

Sorry!

ping @nodejs/releasers

CI: https://ci.nodejs.org/job/node-test-pull-request/52105/

@anonrig Could you take a look at the test failures?

node-test-pull-request ci: https://ci.nodejs.org/job/node-test-pull-request/52413/

CI: https://ci.nodejs.org/job/node-test-pull-request/52688/

CI: https://ci.nodejs.org/job/node-test-pull-request/52689/

CI: https://ci.nodejs.org/job/node-test-pull-request/52694/

CI: https://ci.nodejs.org/job/node-test-pull-request/52722/

CI: https://ci.nodejs.org/job/node-test-pull-request/52728/

PR-URL: #46867 Backport-PR-URL: #48345 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>

PR-URL: #46884 Backport-PR-URL: #48345 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

PR-URL: #46904 Backport-PR-URL: #48345 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

PR-URL: #46989 Backport-PR-URL: #48345 Fixes: #46981 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: #47001 Backport-PR-URL: #48345 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Darshan Sen <raisinten@gmail.com>

Implements a review suggestion from 72e971e. Refs: #47001 (comment) PR-URL: #47035 Backport-PR-URL: #48345 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

PR-URL: #47179 Backport-PR-URL: #48345 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>

PR-URL: #47339 Backport-PR-URL: #48345 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

PR-URL: #47547 Backport-PR-URL: #48345 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #47598 Backport-PR-URL: #48345 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

PR-URL: #47678 Backport-PR-URL: #48345 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

PR-URL: #47737 Backport-PR-URL: #48345 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #47893 Backport-PR-URL: #48345 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

PR-URL: #47922 Backport-PR-URL: #48345 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

PR-URL: #48036 Backport-PR-URL: #48345 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

PR-URL: #48092 Backport-PR-URL: #48345 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #48223 Backport-PR-URL: #48345 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Landed in 5d910ca...6f3a8b4

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. v18.x whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Jun 5, 2023

anonrig marked this pull request as ready for review June 5, 2023 14:43

This comment was marked as outdated.

Sign in to view

anonrig requested review from RafaelGSS, danielleadams, ruyadorno and targos June 5, 2023 14:46

anonrig force-pushed the backport-ada-v2-to-v18.x branch 2 times, most recently from 0015d46 to 8e1fe70 Compare June 5, 2023 14:55

anonrig force-pushed the backport-ada-v2-to-v18.x branch from 8e1fe70 to 82221be Compare June 5, 2023 15:48

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2023

github-actions Bot mentioned this pull request Jun 6, 2023

CI Reliability 2023-06-06 nodejs/reliability#587

Open

20 tasks

This was referenced Jun 9, 2023

CI Reliability 2023-06-09 nodejs/reliability#588

Open

CI Reliability 2023-06-10 nodejs/reliability#589

Open

CI Reliability 2023-06-11 nodejs/reliability#590

Open

anonrig force-pushed the backport-ada-v2-to-v18.x branch 2 times, most recently from e51bc6c to c335b74 Compare June 17, 2023 02:35

RafaelGSS force-pushed the v18.x-staging branch from b749323 to e5e385d Compare June 20, 2023 20:25

anonrig force-pushed the backport-ada-v2-to-v18.x branch 2 times, most recently from 0f267b0 to 2c34b15 Compare June 23, 2023 23:33

danielleadams pushed a commit that referenced this pull request Jul 12, 2023

url: allow extension of user provided URL objects

4784e64

PR-URL: #46989 Backport-PR-URL: #48345 Fixes: #46981 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

danielleadams pushed a commit that referenced this pull request Jul 12, 2023

url: implement URL.canParse

11f48e0

PR-URL: #47179 Backport-PR-URL: #48345 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>

danielleadams pushed a commit that referenced this pull request Jul 12, 2023

deps: update ada to 2.0.0

96c50ba

PR-URL: #47339 Backport-PR-URL: #48345 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

danielleadams pushed a commit that referenced this pull request Jul 12, 2023

url: use ada::url_aggregator for parsing urls

b395b16

PR-URL: #47339 Backport-PR-URL: #48345 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

danielleadams pushed a commit that referenced this pull request Jul 12, 2023

url: drop ICU requirement for parsing hostnames

0dc485e

PR-URL: #47339 Backport-PR-URL: #48345 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

danielleadams pushed a commit that referenced this pull request Jul 12, 2023

deps: update ada to 2.2.0

42e690f

PR-URL: #47678 Backport-PR-URL: #48345 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

danielleadams pushed a commit that referenced this pull request Jul 12, 2023

deps: update ada to 2.3.1

575ddf6

PR-URL: #47893 Backport-PR-URL: #48345 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

danielleadams pushed a commit that referenced this pull request Jul 12, 2023

deps: update ada to 2.4.0

81b514d

PR-URL: #47922 Backport-PR-URL: #48345 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

danielleadams closed this Jul 12, 2023

github-actions Bot mentioned this pull request Jul 16, 2023

CI Reliability 2023-07-16 nodejs/reliability#614

Open

23 tasks

ckerr mentioned this pull request Jul 20, 2023

chore: bump node to v18.17.0 (main) electron/electron#39154

Merged

MattIPv4 mentioned this pull request Aug 25, 2023

url.parse regression in 18.17+ #49330

Closed

[v18.x] backport Ada v2.x to Node.js v18 by anonrig · Pull Request #48345 · nodejs/node · GitHub

Uh oh!

Uh oh!

[v18.x] backport Ada v2.x to Node.js v18 - #48345

[v18.x] backport Ada v2.x to Node.js v18#48345anonrig wants to merge 20 commits intonodejs:v18.x-stagingnodejs/node:v18.x-stagingfrom anonrig:backport-ada-v2-to-v18.xanonrig/node:backport-ada-v2-to-v18.xCopy head branch name to clipboard

Conversation

anonrig commented Jun 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Backports

Uh oh!

nodejs-github-bot commented Jun 5, 2023

Uh oh!

This comment was marked as outdated.

richardlau commented Jun 5, 2023

Uh oh!

anonrig commented Jun 5, 2023

Uh oh!

nodejs-github-bot commented Jun 5, 2023

Uh oh!

richardlau commented Jun 6, 2023

Uh oh!

anonrig commented Jun 24, 2023

Uh oh!

nodejs-github-bot commented Jul 11, 2023

Uh oh!

nodejs-github-bot commented Jul 11, 2023

Uh oh!

nodejs-github-bot commented Jul 11, 2023

Uh oh!

nodejs-github-bot commented Jul 12, 2023

Uh oh!

nodejs-github-bot commented Jul 12, 2023

Uh oh!

danielleadams commented Jul 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

[v18.x] backport Ada v2.x to Node.js v18#48345
anonrig wants to merge 20 commits into
nodejs:v18.x-stagingfrom
anonrig:backport-ada-v2-to-v18.x

anonrig commented Jun 5, 2023 •
edited
Loading