FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: update ada to 2.2.0 by nodejs-github-bot · Pull Request #47678 · nodejs/node · GitHub

/ node Public

deps: update ada to 2.2.0 - #47678

Merged
nodejs-github-bot merged 2 commits into
mainfrom
actions/tools-update-ada
Apr 25, 2023
ConversationCommits (2)ChecksFiles changed
Merged

deps: update ada to 2.2.0#47678
nodejs-github-bot merged 2 commits into
mainfrom
actions/tools-update-ada

Conversation

nodejs-github-bot commented Apr 23, 2023

Copy link
Copy Markdown
Collaborator

This is an automated update of ada to 2.2.0.

nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Apr 23, 2023

nodejs-github-bot commented Apr 23, 2023

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/url

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 23, 2023

anonrig commented Apr 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

We have couple of breaking changes. I'll update this pull request.

anonrig self-assigned this Apr 23, 2023
anonrig added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 23, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 23, 2023

nodejs-github-bot commented Apr 23, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51440/

anonrig commented Apr 23, 2023

Copy link
Copy Markdown
Member

@nodejs/url please review

nodejs-github-bot commented Apr 24, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51441/

github-actions Bot mentioned this pull request Apr 24, 2023
Open
39 tasks
anonrig added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 24, 2023
benjamingr approved these changes Apr 24, 2023
View reviewed changes

benjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 24, 2023
github-actions Bot mentioned this pull request Apr 25, 2023
Open
38 tasks
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 25, 2023
nodejs-github-bot merged commit 25b6ddf into main Apr 25, 2023

nodejs-github-bot commented Apr 25, 2023

Copy link
Copy Markdown
Collaborator Author

Landed in 25b6ddf

nodejs-github-bot deleted the actions/tools-update-ada branch April 25, 2023 00:47
This was referenced Apr 26, 2023
Open
Open
Open
github-actions Bot mentioned this pull request Apr 29, 2023
Open
32 tasks
targos pushed a commit that referenced this pull request May 2, 2023
deps: update ada to 2.2.0
f3ee312 
PR-URL: #47678
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos mentioned this pull request May 2, 2023
Merged
anonrig mentioned this pull request Jun 5, 2023
Closed
19 tasks
anonrig pushed a commit to anonrig/node that referenced this pull request Jul 9, 2023
deps: update ada to 2.2.0
40d27a7 
PR-URL: nodejs#47678
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
deps: update ada to 2.2.0
42e690f 
PR-URL: #47678
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams mentioned this pull request Jul 12, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjamingr benjamingr approved these changes
anonrig anonrig approved these changes
+1 more reviewer
aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

anonrig

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL