FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: update ada to 2.4.0 by nodejs-github-bot · Pull Request #47922 · nodejs/node · GitHub

/ node Public

deps: update ada to 2.4.0 - #47922

Merged
nodejs-github-bot merged 1 commit into
mainfrom
actions/tools-update-ada
May 9, 2023
ConversationCommits (1)ChecksFiles changed
Merged

deps: update ada to 2.4.0#47922
nodejs-github-bot merged 1 commit into
mainfrom
actions/tools-update-ada

Conversation

nodejs-github-bot commented May 8, 2023 •
edited by anonrig
Loading

Copy link
Copy Markdown
Collaborator

This is an automated update of ada to 2.4.0.

Fixes #47894

nodejs-github-bot added the dependencies Pull requests that update a dependency file. label May 8, 2023

nodejs-github-bot commented May 8, 2023 •
edited by anonrig
Loading

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/url

nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 8, 2023
anonrig added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. fast-track PRs that do not need to wait for 48 hours to land. labels May 8, 2023

github-actions Bot commented May 8, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

anonrig commented May 8, 2023

Copy link
Copy Markdown
Member

cc @RaisinTen @bnoordhuis @tniessen

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2023

nodejs-github-bot commented May 8, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51703/

anonrig mentioned this pull request May 8, 2023
Closed
github-actions Bot mentioned this pull request May 9, 2023
Open
29 tasks
RaisinTen approved these changes May 9, 2023
View reviewed changes

RaisinTen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2023
nodejs-github-bot merged commit a6ad5d8 into main May 9, 2023

nodejs-github-bot commented May 9, 2023

Copy link
Copy Markdown
Collaborator Author

Landed in a6ad5d8

nodejs-github-bot deleted the actions/tools-update-ada branch May 9, 2023 15:53
github-actions Bot mentioned this pull request May 10, 2023
Open
25 tasks
targos pushed a commit that referenced this pull request May 12, 2023
deps: update ada to 2.4.0
c2b14b4 
PR-URL: #47922
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos mentioned this pull request May 15, 2023
Merged
anonrig mentioned this pull request Jun 5, 2023
Closed
19 tasks
anonrig pushed a commit to anonrig/node that referenced this pull request Jul 9, 2023
deps: update ada to 2.4.0
461c1e9 
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
deps: update ada to 2.4.0
81b514d 
PR-URL: #47922
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams mentioned this pull request Jul 12, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lemire lemire approved these changes
lpinca lpinca approved these changes
anonrig anonrig approved these changes
RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. dependencies Pull requests that update a dependency file. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ada's license

6 participants

Back | FazBrowse Home | New Git URL