src: improve error message for invalid child stdio type in spawn_sync · nodejs/node@ab0d3a3 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 759
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit ab0d3a3

Browse filesBrowse the repository at this point in the historyBrowse files

dario-piotrowicz

authored and

aduh95

committed

src: improve error message for invalid child stdio type in spawn_sync

PR-URL: #57589 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

1 parent 24b182e commit ab0d3a3
Copy full SHA for ab0d3a3

1 file changed

+4-1Lines changed: 4 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • spawn_sync.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/spawn_sync.cc‎

Copy file name to clipboardExpand all lines: src/spawn_sync.cc

+4-1Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1055,7 +1055,10 @@ Maybe<int> SyncProcessRunner::ParseStdioOption(int child_fd,
1055	1055	return Just(AddStdioInheritFD(child_fd, inherit_fd));
1056	1056	}
1057	1057
1058		- UNREACHABLE("invalid child stdio type");
	1058	+ Utf8Value stdio_type(env()->isolate(), js_type);
	1059	+ fprintf(stderr, "invalid child stdio type: %s\n", stdio_type.out());
	1060	+
	1061	+ UNREACHABLE();
1059	1062	}
1060	1063
1061	1064	int SyncProcessRunner::AddStdioIgnore(uint32_t child_fd) {

0 commit comments

Comments

0 (0)