FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: improve error message for invalid child stdio type in spawn_sync by dario-piotrowicz · Pull Request #57589 · nodejs/node · GitHub

/ node Public

src: improve error message for invalid child stdio type in spawn_sync - #57589

Closed
dario-piotrowicz wants to merge 1 commit into
nodejs:mainfrom
dario-piotrowicz:dario/spawn_sync_invalid_child_stdio_type_error_message
ConversationCommits (1)ChecksFiles changed
Closed

src: improve error message for invalid child stdio type in spawn_sync#57589
dario-piotrowicz wants to merge 1 commit into
nodejs:mainfrom
dario-piotrowicz:dario/spawn_sync_invalid_child_stdio_type_error_message

Conversation

dario-piotrowicz commented Mar 22, 2025

Copy link
Copy Markdown
Member

This is pretty minor, but as I was looking into #52776 (which I still am) and I noticed that the current error message that users see is not super helpful:

  #  Assertion failed: "Unreachable code reached" __VA_OPT__(": ") "invalid child stdio type"

What I'm doing in here is simply updating this so that instead what the user sees the following:

invalid child stdio type: wrap

  #  <node binary location>[192863]: v8::Maybe<int> node::SyncProcessRunner::ParseStdioOption(int, v8::Local<v8::Object>) at ../src/spawn_sync.cc:1061
  #  Assertion failed: "Unreachable code reached"

(where wrap is the problematic stdio type I get for #52776)

I'm not really good at C++ (I'm still learning), so if there is a better way of doing the above I would really love
some suggestions 🙂

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. labels Mar 22, 2025

codecov Bot commented Mar 22, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.24%. Comparing base (86f86a2) to head (d7cf57b).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/spawn_sync.cc 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57589      +/-   ##
==========================================
+ Coverage   90.22%   90.24%   +0.01%     
==========================================
  Files         630      630              
  Lines      185481   185483       +2     
  Branches    36364    36366       +2     
==========================================
+ Hits       167357   167382      +25     
+ Misses      11004    10992      -12     
+ Partials     7120     7109      -11
Files with missing lines Coverage Δ
src/spawn_sync.cc 68.57% <0.00%> (-0.19%) ⬇️

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

anonrig requested review from anonrig and jasnell and removed request for jasnell March 24, 2025 20:07
anonrig added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. review wanted PRs that need reviews. labels Mar 24, 2025

anonrig commented Mar 24, 2025

Copy link
Copy Markdown
Member

cc @nodejs/cpp-reviewers

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2025

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view
dario-piotrowicz force-pushed the dario/spawn_sync_invalid_child_stdio_type_error_message branch from fb26425 to d7cf57b Compare April 12, 2025 15:46

nodejs-github-bot commented Apr 12, 2025 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66219/ 💛

jasnell pushed a commit that referenced this pull request Apr 13, 2025
src: improve error message for invalid child stdio type in spawn_sync
a4843f4 
PR-URL: #57589
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

jasnell commented Apr 13, 2025

Copy link
Copy Markdown
Member

Landed in a4843f4

jasnell closed this Apr 13, 2025
dario-piotrowicz deleted the dario/spawn_sync_invalid_child_stdio_type_error_message branch April 13, 2025 17:20
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
src: improve error message for invalid child stdio type in spawn_sync
c8bb3fe 
PR-URL: #57589
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
src: improve error message for invalid child stdio type in spawn_sync
8c5f9b4 
PR-URL: #57589
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
src: improve error message for invalid child stdio type in spawn_sync
88ca6d0 
PR-URL: #57589
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
src: improve error message for invalid child stdio type in spawn_sync
933248b 
PR-URL: #57589
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
src: improve error message for invalid child stdio type in spawn_sync
66b0cdf 
PR-URL: #57589
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
src: improve error message for invalid child stdio type in spawn_sync
8085cfe 
PR-URL: #57589
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
src: improve error message for invalid child stdio type in spawn_sync
6672ffc 
PR-URL: #57589
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
aduh95 pushed a commit that referenced this pull request May 18, 2025
src: improve error message for invalid child stdio type in spawn_sync
39ac9a2 
PR-URL: #57589
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
github-actions Bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
src: improve error message for invalid child stdio type in spawn_sync
ab0d3a3 
PR-URL: #57589
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
ghost mentioned this pull request Jun 8, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
anonrig anonrig approved these changes
joyeecheung joyeecheung approved these changes
Ethan-Arrowood Ethan-Arrowood approved these changes
RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. review wanted PRs that need reviews.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL